You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/05/26 04:47:13 UTC

[GitHub] [skywalking-query-protocol] kezhenxu94 opened a new pull request #58: Add more topology template types

kezhenxu94 opened a new pull request #58:
URL: https://github.com/apache/skywalking-query-protocol/pull/58


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-query-protocol] wu-sheng merged pull request #58: Add more topology template types

Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #58:
URL: https://github.com/apache/skywalking-query-protocol/pull/58


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull request #58: Add more topology template types

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #58:
URL: https://github.com/apache/skywalking-query-protocol/pull/58#discussion_r639398142



##########
File path: ui-configuration.graphqls
##########
@@ -21,7 +21,10 @@ enum TemplateType {
     TOPOLOGY_INSTANCE,
     TOPOLOGY_ENDPOINT,
     TOPOLOGY_SERVICE_RELATION,
-    TOPOLOGY_SERVICE_INSTANCE_RELATION
+    TOPOLOGY_SERVICE_INSTANCE_RELATION,
+    TOPOLOGY_ENDPOINT_DEPENDENCY,
+    TOPOLOGY_SERVICE_DEPENDENCY,

Review comment:
       What is the different between relationship and dependency?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-query-protocol] kezhenxu94 commented on a change in pull request #58: Add more topology template types

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #58:
URL: https://github.com/apache/skywalking-query-protocol/pull/58#discussion_r639401537



##########
File path: ui-configuration.graphqls
##########
@@ -21,7 +21,10 @@ enum TemplateType {
     TOPOLOGY_INSTANCE,
     TOPOLOGY_ENDPOINT,
     TOPOLOGY_SERVICE_RELATION,
-    TOPOLOGY_SERVICE_INSTANCE_RELATION
+    TOPOLOGY_SERVICE_INSTANCE_RELATION,
+    TOPOLOGY_ENDPOINT_DEPENDENCY,
+    TOPOLOGY_SERVICE_DEPENDENCY,

Review comment:
       > What is the different between relationship and dependency?
   
   Overlooked those `*_RELATION`, so they were not used and now can be used.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org