You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/09 18:08:11 UTC
[GitHub] [arrow] zeroshade opened a new pull request, #13828: ARROW-17326: [Go][FlightSQL] Add FlightSQL support for Go
zeroshade opened a new pull request, #13828:
URL: https://github.com/apache/arrow/pull/13828
This implements initial support for FlightSQL in Golang and is sufficient to pass the flight_sql integration scenario.
As a follow-up in a subsequent PR i'll implement an equivalent example to the C++ SQLite example using Go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #13828: ARROW-17326: [Go][FlightSQL] Add FlightSQL support for Go
Posted by GitBox <gi...@apache.org>.
zeroshade commented on PR #13828:
URL: https://github.com/apache/arrow/pull/13828#issuecomment-1212127089
I'll give this till end of today and then merge if no one has any comments or asks me to wait for them to have a chance to look through it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #13828: ARROW-17326: [Go][FlightSQL] Add FlightSQL support for Go
Posted by GitBox <gi...@apache.org>.
zeroshade merged PR #13828:
URL: https://github.com/apache/arrow/pull/13828
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a diff in pull request #13828: ARROW-17326: [Go][FlightSQL] Add FlightSQL support for Go
Posted by GitBox <gi...@apache.org>.
lidavidm commented on code in PR #13828:
URL: https://github.com/apache/arrow/pull/13828#discussion_r941737942
##########
go/arrow/array/record_test.go:
##########
@@ -135,8 +135,8 @@ func TestRecord(t *testing.T) {
{
schema: schema,
cols: nil,
- rows: -1,
- err: fmt.Errorf("arrow/array: number of columns/fields mismatch"),
+ rows: 0,
+ // err: fmt.Errorf("arrow/array: number of columns/fields mismatch"),
Review Comment:
Are the changes in record/record_test incidental? Or else, do they deserve their own PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13828: ARROW-17326: [Go][FlightSQL] Add FlightSQL support for Go
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13828:
URL: https://github.com/apache/arrow/pull/13828#issuecomment-1212628024
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/51eae2f870e14014af6978a1c94181a0...89c72325ec9d4483a476844dbf3f5dac/)
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5ad012a204364f93942508ca1cc38a82...87775bd1aea3461dafef69255ba148c0/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13828: ARROW-17326: [Go][FlightSQL] Add FlightSQL support for Go
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13828:
URL: https://github.com/apache/arrow/pull/13828#issuecomment-1209709102
https://issues.apache.org/jira/browse/ARROW-17326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13828: ARROW-17326: [Go][FlightSQL] Add FlightSQL support for Go
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13828:
URL: https://github.com/apache/arrow/pull/13828#issuecomment-1212627903
Benchmark runs are scheduled for baseline = 89b39bcd576b25999c294b7694a934dd1fd67e82 and contender = e8ed4c2fe2f7d19cbb8b622274280b344ed4797b. e8ed4c2fe2f7d19cbb8b622274280b344ed4797b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8967c2f9077245d6b5d0f4a0d8b003cd...df74a561b03847e4b9f515a97a1aa82f/)
[Failed :arrow_down:0.54% :arrow_up:0.1%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/51eae2f870e14014af6978a1c94181a0...89c72325ec9d4483a476844dbf3f5dac/)
[Failed :arrow_down:0.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/5ad012a204364f93942508ca1cc38a82...87775bd1aea3461dafef69255ba148c0/)
[Finished :arrow_down:0.68% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e69c7271fdab4de5a02f1ca5123b54c6...d2c2b9b7bc884d2b95f4403c59f19b18/)
Buildkite builds:
[Finished] [`e8ed4c2f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1295)
[Finished] [`e8ed4c2f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1311)
[Failed] [`e8ed4c2f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1293)
[Finished] [`e8ed4c2f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1310)
[Finished] [`89b39bcd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/1294)
[Failed] [`89b39bcd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/1310)
[Failed] [`89b39bcd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1292)
[Finished] [`89b39bcd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/1309)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on a diff in pull request #13828: ARROW-17326: [Go][FlightSQL] Add FlightSQL support for Go
Posted by GitBox <gi...@apache.org>.
zeroshade commented on code in PR #13828:
URL: https://github.com/apache/arrow/pull/13828#discussion_r941803598
##########
go/arrow/array/record_test.go:
##########
@@ -135,8 +135,8 @@ func TestRecord(t *testing.T) {
{
schema: schema,
cols: nil,
- rows: -1,
- err: fmt.Errorf("arrow/array: number of columns/fields mismatch"),
+ rows: 0,
+ // err: fmt.Errorf("arrow/array: number of columns/fields mismatch"),
Review Comment:
ah, so prior to these changes attempting to construct an empty record without having *actual* empty arrays was failing. But several of the tests and examples involve passing an empty record batch. So I made a change allowing someone to pass either a nil slice or a len(0) slice of columns *only* when rows == 0 as a shortcut to making an empty record without having to create a full slice of empty arrays for the columns.
I should probably remove the comment there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org