[jira] [Comment Edited] (HIVE-14170) Beeline IncrementalRows should buffer rows and incrementally re-calculate width if TableOutputFormat is used

["Sahil Takiar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-14170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15447093#comment-15447093 ] 

Sahil Takiar edited comment on HIVE-14170 at 8/29/16 9:26 PM:
--------------------------------------------------------------

You can test this locally by:

* Applying the patch locally
* Building the code, un-tarring the distribution, etc.
* Run Beeline with the --incremental and --incrementalBufferRows=5 options
* Load some dummy data into a table (15 rows should be sufficient, you can just have a single column that is a string; ideally each row is of varying length)
* Run a {{select *}} from the table

The output that is printed should show that the width of the output table is re-calculated every 5 rows. Note you can really only see this if the rows are of varying length. You can also run this without the {{--incremental}} to see what the output looks if a global width calculation is done.


was (Author: stakiar):
You can test this locally by:

* Applying the patch locally
* Building the code, un-tarring the distribution, etc.
* Run Beeline with the {{--incremental}} and {{--incrementalBufferRows=5}} options
* Load some dummy data into a table (15 rows should be sufficient, you can just have a single column that is a string; ideally each row is of varying length)
* Run a {{select *}} from the table

The output that is printed should show that the width of the output table is re-calculated every 5 rows. Note you can really only see this if the rows are of varying length. You can also run this without the {{--incremental}} to see what the output looks if a global width calculation is done.

> Beeline IncrementalRows should buffer rows and incrementally re-calculate width if TableOutputFormat is used
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-14170
>                 URL: https://issues.apache.org/jira/browse/HIVE-14170
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Beeline
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>         Attachments: HIVE-14170.1.patch, HIVE-14170.2.patch, HIVE-14170.3.patch, HIVE-14170.4.patch
>
>
> If {{--incremental}} is specified in Beeline, rows are meant to be printed out immediately. However, if {{TableOutputFormat}} is used with this option the formatting can look really off.
> The reason is that {{IncrementalRows}} does not do a global calculation of the optimal width size for {{TableOutputFormat}} (it can't because it only sees one row at a time). The output of {{BufferedRows}} looks much better because it can do this global calculation.
> If {{--incremental}} is used, and {{TableOutputFormat}} is used, the width should be re-calculated every "x" rows ("x" can be configurable and by default it can be 1000).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)