You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/30 13:10:29 UTC
[GitHub] [airflow] potiuk opened a new pull request #17913: Fix saving last choice of backend and other flags between breeze runs
potiuk opened a new pull request #17913:
URL: https://github.com/apache/airflow/pull/17913
Breeze used to have the ability of storing the last choice of
backend and few other flags in the ".BUILD" directory. While
they were saved, one of the refactors changing the sequence
of initialization made the default value to override the one
provided by the .BUILD directory.
This PR changes the sequence of initialization slightly:
1) First we make sure that the .BUILD and few other temp dirs
are created
2) Then we read variables stored there (if they are stored)
3) Then we follow through to the next steps of initialization and
set the default values for parameters that do not have the
values set yet
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17913: Fix saving last choice of backend and other flags between breeze runs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17913:
URL: https://github.com/apache/airflow/pull/17913#issuecomment-908589203
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17913: Fix saving last choice of backend and other flags between breeze runs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17913:
URL: https://github.com/apache/airflow/pull/17913#issuecomment-908589203
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17913: Fix saving last choice of backend and other flags between breeze runs
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17913:
URL: https://github.com/apache/airflow/pull/17913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17913: Fix saving last choice of backend and other flags between breeze runs
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17913:
URL: https://github.com/apache/airflow/pull/17913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org