[GitHub] [superset] Always-prog commented on a diff in pull request #25282: fix(nativeFilters): Speed up native filters by removing unnecessary rerenders

["Always-prog (via GitHub)" <gi...@apache.org>]

Always-prog commented on code in PR #25282:
URL: https://github.com/apache/superset/pull/25282#discussion_r1325542583


##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx:
##########
@@ -166,7 +167,7 @@ const FilterBar: React.FC<FiltersBarProps> = ({
         };
       });
     },
-    [dataMaskSelected, dispatch, setDataMaskSelected],
+    [JSON.stringify(dataMaskSelected), dispatch, setDataMaskSelected],

Review Comment:
   Thanks for response!
   Yeah, using ref works as well. I added it to FilterBar and Vertical filter bar instead of JSON.stringifying selected dataMask.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org