You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Danilo Tuler (JIRA)" <ji...@apache.org> on 2006/08/18 18:30:23 UTC

[jira] Created: (AMQ-884) Ajax should support non-XML messages

Ajax should support non-XML messages
------------------------------------

                 Key: AMQ-884
                 URL: https://issues.apache.org/activemq/browse/AMQ-884
             Project: ActiveMQ
          Issue Type: Bug
    Affects Versions: 4.0.1
            Reporter: Danilo Tuler


_amq.js should not make an assumption that the received message is in XML format.
I'm using a plain text message and it was not being handled to my handler.
The user handler must be aware of the type of object it receives.
Patch below.

Index: _amq.js
===================================================================
--- _amq.js	(revision 419888)
+++ _amq.js	(working copy)
@@ -46,11 +46,7 @@
             {
               for (var j = 0; j < responseElement.childNodes.length; j++)
               {
-                var child = responseElement.childNodes[j]
-                if (child.nodeType == 1)
-                {
-                  handler(child);
-                }
+                handler(responseElement.childNodes[j]);
 	      }
             }
           }


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Resolved: (AMQ-884) Ajax should support non-XML messages

Posted by "Greg Wilkins (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-884?page=all ]

Greg Wilkins resolved AMQ-884.
------------------------------

    Resolution: Fixed

Applied patch and tested against chat demo.
Also updated to jetty 6.0.0rc2


> Ajax should support non-XML messages
> ------------------------------------
>
>                 Key: AMQ-884
>                 URL: https://issues.apache.org/activemq/browse/AMQ-884
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 4.0.1
>            Reporter: Danilo Tuler
>         Assigned To: Greg Wilkins
>         Attachments: _amq.js.patch
>
>
> _amq.js should not make an assumption that the received message is in XML format.
> I'm using a plain text message and it was not being handled to my handler.
> The user handler must be aware of the type of object it receives.
> Patch below.
> Index: _amq.js
> ===================================================================
> --- _amq.js	(revision 419888)
> +++ _amq.js	(working copy)
> @@ -46,11 +46,7 @@
>              {
>                for (var j = 0; j < responseElement.childNodes.length; j++)
>                {
> -                var child = responseElement.childNodes[j]
> -                if (child.nodeType == 1)
> -                {
> -                  handler(child);
> -                }
> +                handler(responseElement.childNodes[j]);
>  	      }
>              }
>            }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (AMQ-884) Ajax should support non-XML messages

Posted by "Danilo Tuler (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-884?page=all ]

Danilo Tuler updated AMQ-884:
-----------------------------

    Attachment: _amq.js.patch

> Ajax should support non-XML messages
> ------------------------------------
>
>                 Key: AMQ-884
>                 URL: https://issues.apache.org/activemq/browse/AMQ-884
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 4.0.1
>            Reporter: Danilo Tuler
>         Attachments: _amq.js.patch
>
>
> _amq.js should not make an assumption that the received message is in XML format.
> I'm using a plain text message and it was not being handled to my handler.
> The user handler must be aware of the type of object it receives.
> Patch below.
> Index: _amq.js
> ===================================================================
> --- _amq.js	(revision 419888)
> +++ _amq.js	(working copy)
> @@ -46,11 +46,7 @@
>              {
>                for (var j = 0; j < responseElement.childNodes.length; j++)
>                {
> -                var child = responseElement.childNodes[j]
> -                if (child.nodeType == 1)
> -                {
> -                  handler(child);
> -                }
> +                handler(responseElement.childNodes[j]);
>  	      }
>              }
>            }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (AMQ-884) Ajax should support non-XML messages

Posted by "james strachan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-884?page=all ]

james strachan reassigned AMQ-884:
----------------------------------

    Assignee: Greg Wilkins

> Ajax should support non-XML messages
> ------------------------------------
>
>                 Key: AMQ-884
>                 URL: https://issues.apache.org/activemq/browse/AMQ-884
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 4.0.1
>            Reporter: Danilo Tuler
>         Assigned To: Greg Wilkins
>         Attachments: _amq.js.patch
>
>
> _amq.js should not make an assumption that the received message is in XML format.
> I'm using a plain text message and it was not being handled to my handler.
> The user handler must be aware of the type of object it receives.
> Patch below.
> Index: _amq.js
> ===================================================================
> --- _amq.js	(revision 419888)
> +++ _amq.js	(working copy)
> @@ -46,11 +46,7 @@
>              {
>                for (var j = 0; j < responseElement.childNodes.length; j++)
>                {
> -                var child = responseElement.childNodes[j]
> -                if (child.nodeType == 1)
> -                {
> -                  handler(child);
> -                }
> +                handler(responseElement.childNodes[j]);
>  	      }
>              }
>            }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (AMQ-884) Ajax should support non-XML messages

Posted by "Greg Wilkins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-884?page=comments#action_36837 ] 
            
Greg Wilkins commented on AMQ-884:
----------------------------------

This is a good idea.  I will apply patch, test and commit soon

> Ajax should support non-XML messages
> ------------------------------------
>
>                 Key: AMQ-884
>                 URL: https://issues.apache.org/activemq/browse/AMQ-884
>             Project: ActiveMQ
>          Issue Type: Bug
>    Affects Versions: 4.0.1
>            Reporter: Danilo Tuler
>         Assigned To: Greg Wilkins
>         Attachments: _amq.js.patch
>
>
> _amq.js should not make an assumption that the received message is in XML format.
> I'm using a plain text message and it was not being handled to my handler.
> The user handler must be aware of the type of object it receives.
> Patch below.
> Index: _amq.js
> ===================================================================
> --- _amq.js	(revision 419888)
> +++ _amq.js	(working copy)
> @@ -46,11 +46,7 @@
>              {
>                for (var j = 0; j < responseElement.childNodes.length; j++)
>                {
> -                var child = responseElement.childNodes[j]
> -                if (child.nodeType == 1)
> -                {
> -                  handler(child);
> -                }
> +                handler(responseElement.childNodes[j]);
>  	      }
>              }
>            }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira