[jira] [Commented] (SLING-3034) Check contents of healtchecks bundle

["Bertrand Delacretaz (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13756062#comment-13756062 ] 

Bertrand Delacretaz commented on SLING-3034:
--------------------------------------------

1) DefaultLoginsHealthCheck

>From the javadocs: "Used to verify that those logins are disabled on production systems" 

That's definitely useful in the context of a "security checklist" health check, where you want to verify that your system is fit for production.

2) SlingRequestStatusHealthCheck

Also from the javadocs: "Typically used to check that a freshly installed Sling-based system is in good shape, contains all required content etc."

Can also be used to verify that demo content is gone from a production system.

Checking the status of internal requests is almost as good as a browser-based check, as that can check that content is present and that the components required to serve that content are active.

3) OsgiScriptBinding

Agree that that doesn't do much, but so far those bindings are not pluggable, so removing it would not really help.

It's currently only used in the "check that no more than N bundles are inactive" sample scenario - making the list of inactive bundles accessible via JMX might be a better way of implementing that.

I'm against removing 1) or 2), we might move them to a different bundle but I'm not sure what that brings. That might be a "slingchecks" bundle as both services are quite Sling-specific.

As for renaming the bundle, I'm not sure if "support" is better than "healthchecks" but why not.




                
> Check contents of healtchecks bundle
> ------------------------------------
>
>                 Key: SLING-3034
>                 URL: https://issues.apache.org/jira/browse/SLING-3034
>             Project: Sling
>          Issue Type: Task
>          Components: Health Check
>            Reporter: Carsten Ziegeler
>             Fix For: healthcheck-api 1.0.0
>
>
> The current healtchecks bundle seems to be a collection of completely different things. I think we should reduce this to the bare minimum as these services are API.
> I think the CompositeHealthCheck is fine, as well as the ScriptableHealthCheck and the JmxAttributeHealthCheck.
> But I think the DefaultLoginsHealthCheck and the SlingRequestStatusHealthCheck should rather be moved out. Checking this stuff might look nice, but it imho it doesn't really provide a huge value. If you want to check the status of a request than you have to go all the way, the client browser would go. Otherwise your server looks fine but still a user does not get anything.
> The OsgiScriptBinding looks like a sample to me, we should rather remove this for now. Bundle information should be availabel as jmx info anyway.
> All services are configuration factories (which is good) but set the name to "org.apache.sling.hc.{classname}". I think we should use the real package name here, I see no good reason to use some fake package name

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira