You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "patrick o'leary (JIRA)" <ji...@apache.org> on 2009/04/06 17:24:13 UTC
[jira] Created: (LUCENE-1588) Update Spatial Lucene sort to use
FieldComparatorSource
Update Spatial Lucene sort to use FieldComparatorSource
-------------------------------------------------------
Key: LUCENE-1588
URL: https://issues.apache.org/jira/browse/LUCENE-1588
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/spatial
Affects Versions: 2.9
Reporter: patrick o'leary
Assignee: patrick o'leary
Priority: Trivial
Fix For: 2.9
Update distance sorting to use FieldComparator sorting as opposed to SortComparator
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-1588) Update Spatial Lucene sort to use
FieldComparatorSource
Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Grant Ingersoll resolved LUCENE-1588.
-------------------------------------
Resolution: Fixed
This was committed.
> Update Spatial Lucene sort to use FieldComparatorSource
> -------------------------------------------------------
>
> Key: LUCENE-1588
> URL: https://issues.apache.org/jira/browse/LUCENE-1588
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Affects Versions: 2.9
> Reporter: patrick o'leary
> Assignee: patrick o'leary
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1588.patch
>
>
> Update distance sorting to use FieldComparator sorting as opposed to SortComparator
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Updated: (LUCENE-1588) Update Spatial Lucene sort to use
FieldComparatorSource
Posted by "patrick o'leary (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
patrick o'leary updated LUCENE-1588:
------------------------------------
Attachment: LUCENE-1588.patch
Deprecate DistanceSortSource and Add DistanceFieldComparator
updated Test case to use DistanceFieldComparator
Usage
{code}
// Create a distance sort
// As the radius filter has performed the distance calculations
// already, pass in the filter to reuse the results.
//
DistanceFieldComparatorSource dsort = new
DistanceFieldComparatorSource(dq.distanceFilter);
Sort sort = new Sort(new SortField("foo", dsort,false));
// Perform the search, using the term query, the serial chain filter, and the
// distance sort
Hits hits = searcher.search(customScore, dq.getFilter(),sort);
{code}
If nobody objects I'll apply this later today
> Update Spatial Lucene sort to use FieldComparatorSource
> -------------------------------------------------------
>
> Key: LUCENE-1588
> URL: https://issues.apache.org/jira/browse/LUCENE-1588
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Affects Versions: 2.9
> Reporter: patrick o'leary
> Assignee: patrick o'leary
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1588.patch
>
>
> Update distance sorting to use FieldComparator sorting as opposed to SortComparator
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org
[jira] Commented: (LUCENE-1588) Update Spatial Lucene sort to use
FieldComparatorSource
Posted by "Mark Miller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697718#action_12697718 ]
Mark Miller commented on LUCENE-1588:
-------------------------------------
hmm - looks like we didnt make FieldComparatorSource serializable like SortComparatorSource -- so no need for the serialVersionUID.
Couple other picky comments:
return void at end of the constructor could go.
might remove the nextReader comment or change it ie this space intentionally left blank.
> Update Spatial Lucene sort to use FieldComparatorSource
> -------------------------------------------------------
>
> Key: LUCENE-1588
> URL: https://issues.apache.org/jira/browse/LUCENE-1588
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Affects Versions: 2.9
> Reporter: patrick o'leary
> Assignee: patrick o'leary
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1588.patch
>
>
> Update distance sorting to use FieldComparator sorting as opposed to SortComparator
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org