[GitHub] [netbeans] ebarboni commented on a diff in pull request #5753: don't block in NBM wizard + skip snapshots + more.

["ebarboni (via GitHub)" <gi...@apache.org>]

ebarboni commented on code in PR #5753:
URL: https://github.com/apache/netbeans/pull/5753#discussion_r1165218333


##########
apisupport/maven.apisupport/src/org/netbeans/modules/maven/apisupport/NbmWizardIterator.java:
##########
@@ -145,11 +149,11 @@ public Set<FileObject> instantiate() throws IOException {
             Map<String,String> additional = Collections.singletonMap("netbeansVersion", version); // NOI18N
             
             if (archetype == NB_MODULE_ARCH) {
-                getLatestArchetypeVersion(NB_MODULE_ARCH);
+                updateToLatestKnownArchetypeVersion(NB_MODULE_ARCH);
                 NBMNativeMWI.instantiate(vi, projFile, version, Boolean.TRUE.equals(wiz.getProperty(OSGIDEPENDENCIES)), null);
 
             } else {
-                getLatestArchetypeVersion(NB_APP_ARCH);
+                updateToLatestKnownArchetypeVersion(NB_APP_ARCH);
                 ArchetypeWizards.createFromArchetype(projFile, vi, archetype, additional, true);

Review Comment:
   The archetype were at Mojohaus, created by Milos Kleint and Jesse Glick at the time they were at Oracle. Same was from nbm-maven-plugin. Milos and Jesse were doing release and also accepted the move to Apache. But the archetype didn't recieve any PR from 2015 until donation. 
   We have the hands on archetype and netbeans so we can do what we want now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists