You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Pi Song (JIRA)" <ji...@apache.org> on 2008/06/18 15:12:44 UTC
[jira] Created: (PIG-275) Grunt fails when it encounter comment
inside comment
Grunt fails when it encounter comment inside comment
----------------------------------------------------
Key: PIG-275
URL: https://issues.apache.org/jira/browse/PIG-275
Project: Pig
Issue Type: Bug
Reporter: Pi Song
Priority: Minor
This will fail:-
{code}
/*
/*
This is inner comment
*/
*/
A = LOAD 'xyz' ;
{code}
We can fix this by changing the way we handle comments in the parser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (PIG-275) Grunt fails when it
encounter comment inside comment
Posted by "Pi Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606133#action_12606133 ]
pi_song edited comment on PIG-275 at 6/18/08 4:10 PM:
------------------------------------------------------
It's not just cool but sometimes you may want to comment out a piece of code that you have a comment on top of it.
If other languages don't support, then it's a good reason why we don't have to support.
was (Author: pi_song):
It's not just cool but sometimes you may want to comment out a piece of code that you have a comment on top of it.
It other languages don't support, then it's a good reason why we don't have to support.
> Grunt fails when it encounter comment inside comment
> ----------------------------------------------------
>
> Key: PIG-275
> URL: https://issues.apache.org/jira/browse/PIG-275
> Project: Pig
> Issue Type: Bug
> Reporter: Pi Song
> Priority: Minor
>
> This will fail:-
> {code}
> /*
>
> /*
> This is inner comment
> */
> */
> A = LOAD 'xyz' ;
> {code}
> We can fix this by changing the way we handle comments in the parser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-275) Grunt fails when it encounter comment
inside comment
Posted by "Pi Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606133#action_12606133 ]
Pi Song commented on PIG-275:
-----------------------------
It's not just cool but sometimes you may want to comment out a piece of code that you have a comment on top of it.
It other languages don't support, then it's a good reason why we don't have to support.
> Grunt fails when it encounter comment inside comment
> ----------------------------------------------------
>
> Key: PIG-275
> URL: https://issues.apache.org/jira/browse/PIG-275
> Project: Pig
> Issue Type: Bug
> Reporter: Pi Song
> Priority: Minor
>
> This will fail:-
> {code}
> /*
>
> /*
> This is inner comment
> */
> */
> A = LOAD 'xyz' ;
> {code}
> We can fix this by changing the way we handle comments in the parser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIG-275) Grunt fails when it encounter comment
inside comment
Posted by "Pi Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Pi Song resolved PIG-275.
-------------------------
Resolution: Won't Fix
> Grunt fails when it encounter comment inside comment
> ----------------------------------------------------
>
> Key: PIG-275
> URL: https://issues.apache.org/jira/browse/PIG-275
> Project: Pig
> Issue Type: Bug
> Reporter: Pi Song
> Priority: Minor
>
> This will fail:-
> {code}
> /*
>
> /*
> This is inner comment
> */
> */
> A = LOAD 'xyz' ;
> {code}
> We can fix this by changing the way we handle comments in the parser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-275) Grunt fails when it encounter comment
inside comment
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605963#action_12605963 ]
Benjamin Reed commented on PIG-275:
-----------------------------------
-1 I agree with Sam. Nested comments are cool, but we should really follow C, C++, and Java on this one and not support nesting.
> Grunt fails when it encounter comment inside comment
> ----------------------------------------------------
>
> Key: PIG-275
> URL: https://issues.apache.org/jira/browse/PIG-275
> Project: Pig
> Issue Type: Bug
> Reporter: Pi Song
> Priority: Minor
>
> This will fail:-
> {code}
> /*
>
> /*
> This is inner comment
> */
> */
> A = LOAD 'xyz' ;
> {code}
> We can fix this by changing the way we handle comments in the parser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-275) Grunt fails when it encounter comment
inside comment
Posted by "Sam Pullara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605956#action_12605956 ]
Sam Pullara commented on PIG-275:
---------------------------------
This has always been illegal for C-style comments... at least in C, C++ and Java. Do we really need to support it?
> Grunt fails when it encounter comment inside comment
> ----------------------------------------------------
>
> Key: PIG-275
> URL: https://issues.apache.org/jira/browse/PIG-275
> Project: Pig
> Issue Type: Bug
> Reporter: Pi Song
> Priority: Minor
>
> This will fail:-
> {code}
> /*
>
> /*
> This is inner comment
> */
> */
> A = LOAD 'xyz' ;
> {code}
> We can fix this by changing the way we handle comments in the parser.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.