[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2776: [NETBEANS-5373] Fixed compatibility with Phing 3

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #2776:
URL: https://github.com/apache/netbeans/pull/2776#discussion_r592657119



##########
File path: php/php.phing/src/org/netbeans/modules/php/phing/exec/PhingExecutable.java
##########
@@ -163,10 +161,7 @@ private PhpExecutable getExecutable(String title) {
     }
 
     private List<String> getRunParams(String[] args) {
-        List<String> params = new ArrayList<>(args.length + 2);
-        params.add(LOGGER_PARAM);
-        params.add(LOGGER_COLOR_VALUE);
-        params.addAll(Arrays.asList(args));
+        List<String> params = Collections.unmodifiableList(Arrays.asList(args));

Review comment:
       this changes the semantics of getRunParams - before the change the returned list was modifiable, now its not anymore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists