You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/24 11:36:38 UTC
[GitHub] [flink] kl0u edited a comment on issue #11322: [FLINK-16376][yarn] Use consistent method to get Yarn application dir…
kl0u edited a comment on issue #11322: [FLINK-16376][yarn] Use consistent method to get Yarn application dir…
URL: https://github.com/apache/flink/pull/11322#issuecomment-603130060
The more I think about it, the more I lean towards leaving the `setupLocalResource()` as it is and add a method that simply calls this method with the `getHomeDirectory` as argument. In production we use the one without the `targetDir` as argument, and in the tests we use the old one.
What do you think @jiasheng55 ? This will allow us to get rid of the mocking as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services