You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BePPPower (via GitHub)" <gi...@apache.org> on 2024/03/07 04:11:37 UTC

[PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

BePPPower opened a new pull request, #31908:
URL: https://github.com/apache/doris/pull/31908

   …alue (#31502)
   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   backport: #31502 
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31908:
URL: https://github.com/apache/doris/pull/31908#issuecomment-1982336852

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 202020 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit e02f7c20faeb1ebb602cb0fd0bac1d80d8d28eef, data reload: false
   
   query1	933	386	382	382
   query2	6534	2296	2121	2121
   query3	6910	198	196	196
   query4	21804	18104	18030	18030
   query5	19720	6535	6474	6474
   query6	282	209	240	209
   query7	4145	304	295	295
   query8	261	221	240	221
   query9	3125	2695	2632	2632
   query10	417	289	296	289
   query11	11308	10682	10548	10548
   query12	121	75	74	74
   query13	5579	653	638	638
   query14	17852	13790	13370	13370
   query15	400	239	241	239
   query16	6459	269	260	260
   query17	1754	1461	876	876
   query18	2323	410	403	403
   query19	217	147	146	146
   query20	76	76	70	70
   query21	189	92	95	92
   query22	5290	5127	4970	4970
   query23	32480	31937	32162	31937
   query24	6985	6559	6611	6559
   query25	523	442	404	404
   query26	522	163	157	157
   query27	1889	288	291	288
   query28	6077	2232	2198	2198
   query29	2837	2817	2564	2564
   query30	239	163	159	159
   query31	904	733	708	708
   query32	69	59	68	59
   query33	381	245	254	245
   query34	845	463	474	463
   query35	1126	927	904	904
   query36	1587	1506	1862	1506
   query37	89	60	59	59
   query38	3099	2946	2893	2893
   query39	1362	1320	1314	1314
   query40	201	90	92	90
   query41	36	32	32	32
   query42	88	85	81	81
   query43	655	580	576	576
   query44	1126	729	725	725
   query45	239	226	225	225
   query46	1224	957	953	953
   query47	1767	1810	1650	1650
   query48	976	700	663	663
   query49	607	366	363	363
   query50	873	621	638	621
   query51	4818	4620	4696	4620
   query52	84	80	72	72
   query53	440	330	316	316
   query54	2641	2466	2460	2460
   query55	88	72	79	72
   query56	220	204	201	201
   query57	1266	1074	1041	1041
   query58	210	188	201	188
   query59	3562	3548	3136	3136
   query60	205	191	210	191
   query61	83	83	85	83
   query62	938	471	529	471
   query63	481	332	335	332
   query64	2397	1478	1423	1423
   query65	3667	3558	3542	3542
   query66	792	380	368	368
   query67	15629	16875	15716	15716
   query68	8273	653	698	653
   query69	562	340	343	340
   query70	1965	1564	1775	1564
   query71	396	304	298	298
   query72	6484	3476	3439	3439
   query73	733	320	325	320
   query74	6240	5810	5879	5810
   query75	4612	3770	3635	3635
   query76	4747	1190	1166	1166
   query77	638	240	245	240
   query78	12591	11624	12849	11624
   query79	11501	654	633	633
   query80	1991	384	382	382
   query81	510	231	223	223
   query82	1418	103	94	94
   query83	167	133	129	129
   query84	261	66	66	66
   query85	1349	282	274	274
   query86	400	441	374	374
   query87	3198	3024	3001	3001
   query88	5128	2303	2312	2303
   query89	465	299	282	282
   query90	1718	209	209	209
   query91	150	122	124	122
   query92	54	51	53	51
   query93	5874	563	543	543
   query94	755	200	208	200
   query95	1117	1068	1075	1068
   query96	640	326	321	321
   query97	6476	6400	6430	6400
   query98	176	180	187	180
   query99	2604	913	951	913
   Total cold run time: 315219 ms
   Total hot run time: 202020 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31908:
URL: https://github.com/apache/doris/pull/31908#issuecomment-1982337337

   TeamCity be ut coverage result:
    Function Coverage: 37.81% (8039/21263) 
    Line Coverage: 29.49% (65597/222417)
    Region Coverage: 28.96% (33755/116574)
    Branch Coverage: 24.79% (17317/69850)
    Coverage Report: http://coverage.selectdb-in.cc/coverage/e02f7c20faeb1ebb602cb0fd0bac1d80d8d28eef_e02f7c20faeb1ebb602cb0fd0bac1d80d8d28eef/report/index.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31908:
URL: https://github.com/apache/doris/pull/31908#issuecomment-1982327968

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 49770 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit e02f7c20faeb1ebb602cb0fd0bac1d80d8d28eef, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17879	4448	4390	4390
   q2	2042	146	140	140
   q3	10465	1912	1889	1889
   q4	10370	1264	1295	1264
   q5	8544	3942	3947	3942
   q6	224	122	123	122
   q7	1994	1584	1595	1584
   q8	9339	2727	2729	2727
   q9	10895	10602	10412	10412
   q10	8672	3522	3512	3512
   q11	432	238	242	238
   q12	469	304	298	298
   q13	18330	3892	4047	3892
   q14	346	344	332	332
   q15	512	461	466	461
   q16	689	598	596	596
   q17	1122	962	927	927
   q18	7275	6955	6782	6782
   q19	1683	1534	1470	1470
   q20	554	304	310	304
   q21	4472	4133	4085	4085
   q22	513	403	404	403
   Total cold run time: 116821 ms
   Total hot run time: 49770 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4353	4311	4287	4287
   q2	315	226	227	226
   q3	4171	4154	4175	4154
   q4	2757	2767	2738	2738
   q5	7256	7221	7159	7159
   q6	238	118	118	118
   q7	3316	2840	2826	2826
   q8	4362	4461	4488	4461
   q9	17087	16984	17009	16984
   q10	4257	4258	4285	4258
   q11	753	714	685	685
   q12	1023	848	849	848
   q13	7183	3714	3737	3714
   q14	456	424	425	424
   q15	491	451	464	451
   q16	770	695	700	695
   q17	3850	3850	3809	3809
   q18	8775	8730	8754	8730
   q19	1717	1727	1681	1681
   q20	2389	2146	2121	2121
   q21	8587	8464	8446	8446
   q22	1035	932	927	927
   Total cold run time: 85141 ms
   Total hot run time: 79742 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31908:
URL: https://github.com/apache/doris/pull/31908#issuecomment-1982314893

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31908:
URL: https://github.com/apache/doris/pull/31908#issuecomment-1982319292

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31908:
URL: https://github.com/apache/doris/pull/31908#issuecomment-1982468284

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

Posted by "BePPPower (via GitHub)" <gi...@apache.org>.
BePPPower commented on PR #31908:
URL: https://github.com/apache/doris/pull/31908#issuecomment-1982314940

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31908:
URL: https://github.com/apache/doris/pull/31908#issuecomment-1982468161

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31908:
URL: https://github.com/apache/doris/pull/31908#issuecomment-1982341035

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 30.71 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit e02f7c20faeb1ebb602cb0fd0bac1d80d8d28eef, data reload: false
   
   query1	0.02	0.02	0.02
   query2	0.06	0.02	0.02
   query3	0.25	0.04	0.05
   query4	1.82	0.06	0.06
   query5	0.54	0.52	0.52
   query6	1.28	0.62	0.62
   query7	0.02	0.01	0.02
   query8	0.04	0.02	0.02
   query9	0.51	0.50	0.48
   query10	0.54	0.52	0.54
   query11	0.12	0.09	0.09
   query12	0.11	0.09	0.09
   query13	0.62	0.61	0.61
   query14	0.80	0.78	0.79
   query15	0.77	0.76	0.76
   query16	0.39	0.37	0.36
   query17	1.00	1.02	1.01
   query18	0.25	0.23	0.26
   query19	1.94	1.86	1.86
   query20	0.02	0.01	0.01
   query21	15.50	0.57	0.55
   query22	2.14	2.10	1.33
   query23	17.24	0.90	1.17
   query24	4.46	1.25	2.73
   query25	0.38	0.09	0.05
   query26	0.68	0.16	0.16
   query27	0.05	0.04	0.03
   query28	7.02	0.72	0.74
   query29	12.71	2.36	2.31
   query30	0.63	0.52	0.51
   query31	2.82	0.39	0.38
   query32	3.42	0.51	0.49
   query33	3.10	3.05	3.02
   query34	15.27	4.82	4.79
   query35	4.84	4.85	4.84
   query36	1.05	1.02	1.02
   query37	0.06	0.05	0.04
   query38	0.04	0.02	0.02
   query39	0.01	0.02	0.01
   query40	0.16	0.14	0.14
   query41	0.08	0.02	0.01
   query42	0.02	0.01	0.01
   query43	0.02	0.02	0.02
   Total cold run time: 102.8 s
   Total hot run time: 30.71 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #31908:
URL: https://github.com/apache/doris/pull/31908#issuecomment-1982343366

   
   Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Load test result on commit e02f7c20faeb1ebb602cb0fd0bac1d80d8d28eef with default session variables
   Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
   Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
   Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
   Insert into select:       20.5 seconds inserted 10000000 Rows, about 487K ops/s
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [Fix](JNI) fix BE core when using JNI to query the empty map type value [doris]

Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #31908:
URL: https://github.com/apache/doris/pull/31908


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org