[GitHub] [incubator-doris] morningman commented on a diff in pull request #9792: [Improvement] optimize scannode concurrency query performance in vectorized engine.

[GitBox <gi...@apache.org>]

morningman commented on code in PR #9792:
URL: https://github.com/apache/incubator-doris/pull/9792#discussion_r884239554


##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -554,8 +575,11 @@ Block* VOlapScanNode::_alloc_block(bool& get_free_block) {
 int VOlapScanNode::_start_scanner_thread_task(RuntimeState* state, int block_per_scanner) {
     std::list<VOlapScanner*> olap_scanners;
     int assigned_thread_num = _running_thread;
-    size_t max_thread = std::min(_volap_scanners.size(),
-                                 static_cast<size_t>(config::doris_scanner_thread_pool_thread_num));
+    size_t max_thread = config::doris_scanner_queue_size;
+    if (config::doris_scanner_row_num > state->batch_size()) {

Review Comment:
   This logic need refine. Actually, no one would change this `doris_scanner_row_num` config, and this `if` condition is always true. So that this `if` condition is meaningless.



##########
be/src/common/config.h:
##########
@@ -746,6 +746,10 @@ CONF_Int32(object_pool_buffer_size, "100");
 // ParquetReaderWrap prefetch buffer size
 CONF_Int32(parquet_reader_max_buffer_size, "50");
 
+// When the rows number reached this limit, will check the filter rate the of bloomfilter
+// if it is lower than a specific threshold, the predicate will be disabled.
+CONF_Int32(bloom_filter_predicate_check_row_num, "1000");

Review Comment:
   ```suggestion
   CONF_mInt32(bloom_filter_predicate_check_row_num, "1000");
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org