[GitHub] arina-ielchiieva commented on a change in pull request #1565: DRILL-6874: CTAS from json to parquet is not working on S3 storage

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1565: DRILL-6874: CTAS from json to parquet is not working on S3 storage
URL: https://github.com/apache/drill/pull/1565#discussion_r239740508
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/AsyncPageReader.java
 ##########
 @@ -417,6 +417,9 @@ public Void call() throws IOException {
       if (totalValuesRead >= totalValuesCount) {
         try {
           queue.put(ReadStatus.EMPTY);
+          // Some InputStreams (like S3ObjectInputStream) should be closed
+          // as soon as possible to make the connection reusable.
+          parent.inputStream.close();
 
 Review comment:
   1. Should we handle any exceptions?
   2. Please rename commit message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services