[GitHub] [hudi] liufangqi commented on a diff in pull request #7001: [HUDI-5061] bulk insert operation don't throw other exception except IOE Exception

[GitBox <gi...@apache.org>]

liufangqi commented on code in PR #7001:
URL: https://github.com/apache/hudi/pull/7001#discussion_r1001330427


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bucket/BucketBulkInsertWriterHelper.java:
##########
@@ -70,7 +70,7 @@ public void write(RowData tuple) throws IOException {
       handle.write(recordKey, partitionPath, record);
     } catch (Throwable throwable) {
       LOG.error("Global error thrown while trying to write records in HoodieRowDataCreateHandle", throwable);
-      throw throwable;
+      throw new IOException(throwable);

Review Comment:
   > can you add the same msg as with L72 within new IOExeption as well.
   
   @nsivabalan THX for your review, that's a good catch. I updated my code as advice on the new commit.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org