You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sivasathyaseeelan (via GitHub)" <gi...@apache.org> on 2024/01/01 12:35:10 UTC
[PR] Added chart examples for left out chart types in issue #16707 [superset]
sivasathyaseeelan opened a new pull request, #26387:
URL: https://github.com/apache/superset/pull/26387
Added chart examples for left out chart types in issue #16707 and modified VizTypeGallery.tsx for rendering thumbnail image in case of no example provided
### SUMMARY
Adding chart examples for Deck.gl:
* Arc
* Grid
* Hexagon
* Path
* Polygon
* Scatterplot
* Screen Grid
* Contour
* Heatmap
* Geojson
And made a change in VizTypeGallery.tsx for rendering thumbnail image in case of no example provided
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
####BEFORE
####AFTER
[Screencast from 01-01-24 02:37:27 PM IST.webm](https://github.com/apache/superset/assets/95441117/a79421ec-d488-4c34-a069-273e82117c09)
### TESTING INSTRUCTIONS
Kindly go to [http://localhost:9000/chart/add](http://localhost:9000/chart/add) and please select any chart so that you can be able to see example images of selected chart
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
Fixes #16707
- [x] Has associated issue: #16707
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [x] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Added chart examples for left out chart types in issue #16707 [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26387:
URL: https://github.com/apache/superset/pull/26387#issuecomment-1874397684
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/26387?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `1 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`29633e7`)](https://app.codecov.io/gh/apache/superset/commit/29633e7d8cad7b52669a9e6f5e064cd34da803a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.14% compared to head [(`1c1224e`)](https://app.codecov.io/gh/apache/superset/pull/26387?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 69.14%.
> Report is 3 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/superset/pull/26387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://app.codecov.io/gh/apache/superset/pull/26387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | 66.66% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/26387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #26387 +/- ##
=======================================
Coverage 69.14% 69.14%
=======================================
Files 1946 1946
Lines 75989 75989
Branches 8479 8479
=======================================
Hits 52544 52544
Misses 21266 21266
Partials 2179 2179
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/26387/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/26387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.46% <66.66%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/26387?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Added chart examples for left out chart types in issue #16707 [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #26387:
URL: https://github.com/apache/superset/pull/26387#issuecomment-1875322234
Thank you for the PR @sivasathyaseeelan. Could you rebase your PR and check how it overlaps with https://github.com/apache/superset/pull/25770? Maybe you can discard some of your changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: Added chart examples for left out chart types in issue #16707 [superset]
Posted by "sivasathyaseeelan (via GitHub)" <gi...@apache.org>.
sivasathyaseeelan closed pull request #26387: fix: Added chart examples for left out chart types in issue #16707
URL: https://github.com/apache/superset/pull/26387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org