[GitHub] [incubator-superset] stuarthu commented on pull request #10480: fix(#10479): dashboard slug is cleared on import

[GitBox <gi...@apache.org>]

stuarthu commented on pull request #10480:
URL: https://github.com/apache/incubator-superset/pull/10480#issuecomment-668329081


   > In order to avoid introducing destructive changes, how about this as an alternative?
   > 
   > 1. Attempt to insert with the given slug
   > 2. If the slug exists (unique key error), add a random postfix to the slug and re-attempt the insert
   > 
   > That would effectively attempt to retain the slug, but fall back to a behavior that preserves existing data.
   
   No, random prefix is unexpected behavior.
   There is a principal in design called least astonishment https://en.wikipedia.org/wiki/Principle_of_least_astonishment.
   Users would hope to import as is and fail if conflict.
   If we altered yaml without notice, that is an astonishment to the user.
   No matter if we remove the slug or append random prefix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org