You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/29 13:05:57 UTC

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7038: ARROW-8593: [C++][Parquet] Fix build with musl libc

fsaintjacques commented on a change in pull request #7038:
URL: https://github.com/apache/arrow/pull/7038#discussion_r417298395



##########
File path: cpp/src/parquet/file_serialize_test.cc
##########
@@ -346,12 +346,12 @@ TEST(TestBufferedRowGroupWriter, DisabledDictionary) {
 }
 
 TEST(TestBufferedRowGroupWriter, MultiPageDisabledDictionary) {
-  const int VALUE_COUNT = 10000;
-  const int PAGE_SIZE = 16384;
+  const int value_count = 10000;

Review comment:
       And moved to constexpr while were at it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org