You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ode.apache.org by bo...@apache.org on 2008/02/07 20:54:23 UTC

svn commit: r619606 - /ode/trunk/axis2/src/main/java/org/apache/ode/axis2/ExternalService.java

Author: boisvert
Date: Thu Feb  7 11:54:15 2008
New Revision: 619606

URL: http://svn.apache.org/viewvc?rev=619606&view=rev
Log:
Better error reporting,
1) faults logged at WARN level
2) normal responses at INFO level
3) for unknown faults, log the full SOAP message for inspection

Modified:
    ode/trunk/axis2/src/main/java/org/apache/ode/axis2/ExternalService.java

Modified: ode/trunk/axis2/src/main/java/org/apache/ode/axis2/ExternalService.java
URL: http://svn.apache.org/viewvc/ode/trunk/axis2/src/main/java/org/apache/ode/axis2/ExternalService.java?rev=619606&r1=619605&r2=619606&view=diff
==============================================================================
--- ode/trunk/axis2/src/main/java/org/apache/ode/axis2/ExternalService.java (original)
+++ ode/trunk/axis2/src/main/java/org/apache/ode/axis2/ExternalService.java Thu Feb  7 11:54:15 2008
@@ -143,8 +143,8 @@
                     MessageContext response = operationClient.getMessageContext(WSDLConstants.MESSAGE_LABEL_IN_VALUE);
                     MessageContext flt = operationClient.getMessageContext(WSDLConstants.MESSAGE_LABEL_FAULT_VALUE);
                     if (response != null && __log.isDebugEnabled())
-                        __log.debug("Got service response: " + response.getEnvelope().toString());
-                    
+                        __log.debug("Service response:\n" + response.getEnvelope().toString());
+
                     if (flt != null) {
                         reply(mexId, operation, flt, true);
                     } else {
@@ -305,23 +305,22 @@
                 response.setMessage(odeMsgEl);
                 if (fault) {
                     if (faultType != null) {
-                        if (__log.isDebugEnabled()) {
-                            __log.debug("FAULT RESPONSE(" + faultType + "): " + DOMUtils.domToString(odeMsgEl));
+                        if (__log.isWarnEnabled()) {
+                            __log.warn("Fault response: faultType=" + faultType + "\n" + DOMUtils.domToString(odeMsgEl));
                         }
                         odeMex.replyWithFault(faultType, response);
                     } else {
-                        if (__log.isDebugEnabled()) {
-                            __log.debug("FAULT RESPONSE(unknown fault type): " + DOMUtils.domToString(odeMsgEl));
+                        if (__log.isWarnEnabled()) {
+                            __log.warn("Fault response: faultType=(unkown)\n" + reply.getEnvelope().toString());
                         }
                         odeMex.replyWithFailure(FailureType.OTHER, reply.getEnvelope().getBody().getFault().getText(), 
                                 OMUtils.toDOM(reply.getEnvelope().getBody()));
                     }
                 } else {
-                    if (__log.isDebugEnabled()) {
-                        __log.debug("RESPONSE (NORMAL): " + DOMUtils.domToString(odeMsgEl));
-                    }
+                            if (__log.isInfoEnabled()) {
+                                __log.info("Response:\n" + DOMUtils.domToString(odeMsgEl));
+                            }
                     odeMex.reply(response);
-
                 }
             } catch (Exception ex) {
                 String errmsg = "Unable to process response: " + ex.getMessage();