[GitHub] [superset] codyml commented on pull request #21974: feat: Adds the DropdownContainer component

[GitBox <gi...@apache.org>]

codyml commented on PR #21974:
URL: https://github.com/apache/superset/pull/21974#issuecomment-1299106093

   @michael-s-molina This looks great, thanks!  Would it be possible to add a prop for customizing the value in the badge?  For horizontal filter bar, I believe we'll need to show the number of active filters, not the total number of filters.  If there was a badge count prop, we could handle calls to `onOverflowingStateChange` by checking which overflowing filters in the dropdown are active and setting the badge accordingly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org