You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/27 04:06:42 UTC

[GitHub] [airflow] mik-laj opened a new pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

mik-laj opened a new pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267
 
 
   It is difficult to understand the configurations of these classes if they contain hidden configuration options. I think that all configuration parameters should be passed by the constructor.
   
   ---
   Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
   
   Make sure to mark the boxes below before creating PR: [x]
   
   - [ ] Description above provides context of the change
   - [ ] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
   - [ ] Unit tests coverage for changes (not needed for documentation changes)
   - [ ] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
   - [ ] Relevant documentation is updated including usage instructions.
   - [ ] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
   
   <sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
   
   ---
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267#discussion_r372657126
 
 

 ##########
 File path: airflow/utils/log/file_task_handler.py
 ##########
 @@ -39,12 +38,20 @@ class FileTaskHandler(logging.Handler):
     :param base_log_folder: Base log folder to place logs.
     :param filename_template: template filename string
     """
-    def __init__(self, base_log_folder: str, filename_template: str):
+    def __init__(
+        self,
+        base_log_folder: str,
+        filename_template: str,
+        worker_server_log_port: int,
 
 Review comment:
   Fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on a change in pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267#discussion_r372657126
 
 

 ##########
 File path: airflow/utils/log/file_task_handler.py
 ##########
 @@ -39,12 +38,20 @@ class FileTaskHandler(logging.Handler):
     :param base_log_folder: Base log folder to place logs.
     :param filename_template: template filename string
     """
-    def __init__(self, base_log_folder: str, filename_template: str):
+    def __init__(
+        self,
+        base_log_folder: str,
+        filename_template: str,
+        worker_server_log_port: int,
 
 Review comment:
   Fixed. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267#issuecomment-579544056
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=h1) Report
   > Merging [#7267](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/c94639f919c187c1a7da1b226db81b1e5220f507?src=pr&el=desc) will **increase** coverage by `53.55%`.
   > The diff coverage is `95.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7267/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #7267       +/-   ##
   ===========================================
   + Coverage    32.4%   85.96%   +53.55%     
   ===========================================
     Files         866      866               
     Lines       40556    40552        -4     
   ===========================================
   + Hits        13144    34862    +21718     
   + Misses      27412     5690    -21722
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/utils/log/gcs\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZ2NzX3Rhc2tfaGFuZGxlci5weQ==) | `37.17% <100%> (+37.17%)` | :arrow_up: |
   | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `98% <100%> (+52.34%)` | :arrow_up: |
   | [airflow/utils/log/s3\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvczNfdGFza19oYW5kbGVyLnB5) | `98.57% <100%> (+78.57%)` | :arrow_up: |
   | [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.33% <100%> (+73.52%)` | :arrow_up: |
   | [airflow/utils/log/file\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV90YXNrX2hhbmRsZXIucHk=) | `90.58% <100%> (+61.37%)` | :arrow_up: |
   | [airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=) | `43.05% <66.66%> (+43.05%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-43.8%)` | :arrow_down: |
   | [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
   | ... and [743 more](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=footer). Last update [c94639f...907da86](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] stale[bot] commented on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267#issuecomment-612541166
 
 
   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267#discussion_r372617259
 
 

 ##########
 File path: airflow/utils/log/file_task_handler.py
 ##########
 @@ -39,12 +38,20 @@ class FileTaskHandler(logging.Handler):
     :param base_log_folder: Base log folder to place logs.
     :param filename_template: template filename string
     """
-    def __init__(self, base_log_folder: str, filename_template: str):
+    def __init__(
+        self,
+        base_log_folder: str,
+        filename_template: str,
+        worker_server_log_port: int,
 
 Review comment:
   The config option is called `worker_log_server_port` - did you give this a slightly different name everywhere on purpose?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] stale[bot] closed pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] mik-laj commented on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267#issuecomment-591698213
 
 
   @ashb WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267#issuecomment-579544056
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=h1) Report
   > Merging [#7267](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/5b199cb86be5b1aefbd8620185033d6f635713c1?src=pr&el=desc) will **decrease** coverage by `0.18%`.
   > The diff coverage is `95.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7267/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #7267      +/-   ##
   ==========================================
   - Coverage   86.66%   86.48%   -0.19%     
   ==========================================
     Files         878      878              
     Lines       41219    41216       -3     
   ==========================================
   - Hits        35722    35644      -78     
   - Misses       5497     5572      +75
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/utils/log/gcs\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZ2NzX3Rhc2tfaGFuZGxlci5weQ==) | `37.17% <100%> (+37.17%)` | :arrow_up: |
   | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `91.07% <100%> (+25.68%)` | :arrow_up: |
   | [airflow/utils/log/s3\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvczNfdGFza19oYW5kbGVyLnB5) | `98.57% <100%> (ø)` | :arrow_up: |
   | [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.33% <100%> (-0.07%)` | :arrow_down: |
   | [airflow/utils/log/file\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV90YXNrX2hhbmRsZXIucHk=) | `90.58% <100%> (+1.82%)` | :arrow_up: |
   | [airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=) | `43.05% <66.66%> (+0.58%)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
   | [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
   | ... and [4 more](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=footer). Last update [5b199cb...d1fe777](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io commented on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267#issuecomment-579544056
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=h1) Report
   > Merging [#7267](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/1988a97e8f687e28a5a39b29677fb514e097753c?src=pr&el=desc) will **decrease** coverage by `0.39%`.
   > The diff coverage is `95.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7267/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master    #7267     +/-   ##
   =========================================
   - Coverage   85.46%   85.06%   -0.4%     
   =========================================
     Files         851      851             
     Lines       40403    40400      -3     
   =========================================
   - Hits        34532    34368    -164     
   - Misses       5871     6032    +161
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/utils/log/gcs\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZ2NzX3Rhc2tfaGFuZGxlci5weQ==) | `37.17% <100%> (+37.17%)` | :arrow_up: |
   | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `98% <100%> (+26.26%)` | :arrow_up: |
   | [airflow/utils/log/s3\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvczNfdGFza19oYW5kbGVyLnB5) | `98.57% <100%> (ø)` | :arrow_up: |
   | [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.33% <100%> (-0.07%)` | :arrow_down: |
   | [airflow/utils/log/file\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV90YXNrX2hhbmRsZXIucHk=) | `90.58% <100%> (+1.82%)` | :arrow_up: |
   | [airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=) | `43.05% <66.66%> (+0.58%)` | :arrow_up: |
   | [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=footer). Last update [1988a97...3959dee](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] codecov-io edited a comment on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267#issuecomment-579544056
 
 
   # [Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=h1) Report
   > Merging [#7267](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/1988a97e8f687e28a5a39b29677fb514e097753c?src=pr&el=desc) will **decrease** coverage by `0.16%`.
   > The diff coverage is `95.23%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7267/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff            @@
   ##           master   #7267      +/-   ##
   =========================================
   - Coverage   85.46%   85.3%   -0.17%     
   =========================================
     Files         851     851              
     Lines       40403   40400       -3     
   =========================================
   - Hits        34532   34462      -70     
   - Misses       5871    5938      +67
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [airflow/utils/log/gcs\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZ2NzX3Rhc2tfaGFuZGxlci5weQ==) | `37.17% <100%> (+37.17%)` | :arrow_up: |
   | [airflow/config\_templates/airflow\_local\_settings.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb25maWdfdGVtcGxhdGVzL2FpcmZsb3dfbG9jYWxfc2V0dGluZ3MucHk=) | `98% <100%> (+26.26%)` | :arrow_up: |
   | [airflow/utils/log/s3\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvczNfdGFza19oYW5kbGVyLnB5) | `98.57% <100%> (ø)` | :arrow_up: |
   | [airflow/utils/log/es\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZXNfdGFza19oYW5kbGVyLnB5) | `93.33% <100%> (-0.07%)` | :arrow_down: |
   | [airflow/utils/log/file\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV90YXNrX2hhbmRsZXIucHk=) | `90.58% <100%> (+1.82%)` | :arrow_up: |
   | [airflow/utils/log/wasb\_task\_handler.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvd2FzYl90YXNrX2hhbmRsZXIucHk=) | `43.05% <66.66%> (+0.58%)` | :arrow_up: |
   | [airflow/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9vcGVyYXRvcnMvbXlzcWxfdG9faGl2ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
   | [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
   | [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
   | [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `45.25% <0%> (-46.72%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/airflow/pull/7267/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=footer). Last update [1988a97...3959dee](https://codecov.io/gh/apache/airflow/pull/7267?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [airflow] ashb commented on a change in pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #7267: [AIRFLOW-6645] Pass the TaskHandlers configuration using the constructor
URL: https://github.com/apache/airflow/pull/7267#discussion_r372617259
 
 

 ##########
 File path: airflow/utils/log/file_task_handler.py
 ##########
 @@ -39,12 +38,20 @@ class FileTaskHandler(logging.Handler):
     :param base_log_folder: Base log folder to place logs.
     :param filename_template: template filename string
     """
-    def __init__(self, base_log_folder: str, filename_template: str):
+    def __init__(
+        self,
+        base_log_folder: str,
+        filename_template: str,
+        worker_server_log_port: int,
 
 Review comment:
   The config option is called `worker_log_server_port` - did you give this a slightly different name on purpose?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services