[GitHub] [solr] madrob commented on a diff in pull request #931: SOLR-16282: Update core admin handler to use pluggable custom actions

[GitBox <gi...@apache.org>]

madrob commented on code in PR #931:
URL: https://github.com/apache/solr/pull/931#discussion_r933473915


##########
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##########
@@ -132,6 +133,14 @@ public static NodeConfig fromConfig(Path solrHome, XmlConfigFile config, boolean
     String nodeName = (String) entries.remove("nodeName");
     if (Strings.isNullOrEmpty(nodeName) && cloudConfig != null) nodeName = cloudConfig.getHost();
 
+    Map<String, String> coreAdminHandlerActions =
+        readNodeListAsNamedList(
+                config, "solr/coreAdminHandlerActions/*[@name]", "<coreAdminHandlerActions>")
+            .asMap()
+            .entrySet()
+            .stream()
+            .collect(Collectors.toMap(item -> item.getKey(), item -> item.getValue().toString()));
+

Review Comment:
   Can we add this as a code comment?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org