You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2009/07/01 20:14:13 UTC
svn commit: r790296 - /tomcat/current/tc5.5.x/STATUS.txt
Author: markt
Date: Wed Jul 1 18:14:12 2009
New Revision: 790296
URL: http://svn.apache.org/viewvc?rev=790296&view=rev
Log:
Votes
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=790296&r1=790295&r2=790296&view=diff
==============================================================================
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Wed Jul 1 18:14:12 2009
@@ -64,55 +64,56 @@
suggested by sebb.
Improvement of http://svn.apache.org/viewvc?rev=789714&view=rev
Port of http://svn.apache.org/viewvc?rev=789803&view=rev from OACC to tc5.5.x.
- +1: rjung, kkolinko
+ +1: rjung, kkolinko, markt
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47389
DeltaManager doesn't do session replication if notifySessionListenersOnReplication=false.
Backport of http://svn.apache.org/viewvc?view=rev&revision=786124 from tc6
resp. http://svn.apache.org/viewvc?view=rev&revision=789821 from OACC.
- +1: rjung, kkolinko
+ +1: rjung, kkolinko, markt
-1:
* Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=46990
Improve locking in cluster membership.
Backport of http://svn.apache.org/viewvc?view=rev&revision=771009 from tc6
resp. http://svn.apache.org/viewvc?view=rev&revision=789826 from OACC.
- +1: rjung, kkolinko
+ +1: rjung, kkolinko, markt
-1:
* Partial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=45447
Add spanish message translations.
Backport of http://svn.apache.org/viewvc?view=rev&revision=698924 from tc6
resp. http://svn.apache.org/viewvc?view=rev&revision=789832 from OACC.
- +1: rjung, kkolinko
+ +1: rjung, kkolinko, markt
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45279
Close socket when closing multicast.
Backport of http://svn.apache.org/viewvc?view=rev&revision=672888 from tc6
resp. http://svn.apache.org/viewvc?view=rev&revision=789837 from OACC.
- +1: rjung, kkolinko
+ +1: rjung, kkolinko, markt
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=45317
Properly output the state transfer timeout for sessions.
Backport of http://svn.apache.org/viewvc?view=rev&revision=674750 from tc6
resp. http://svn.apache.org/viewvc?view=rev&revision=735630 from OACC.
- +1: rjung, kkolinko
+ +1: rjung, kkolinko, markt
-1:
* Fix small memory leak found by find bugs.
Backport of http://svn.apache.org/viewvc?view=rev&revision=717906 from tc6
resp. http://svn.apache.org/viewvc?view=rev&revision=735645 from OACC.
+1: rjung, kkolinko
+ +1: markt - patch does much more than fix a memory leak
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46357
Correct test for host's parent must be an engine
Backport of http://svn.apache.org/viewvc?view=rev&revision=734560 from tc6
resp. http://svn.apache.org/viewvc?view=rev&revision=735629 from OACC.
- +1: rjung, kkolinko
+ +1: rjung, kkolinko, markt
-1:
* Remove obsolete classpath entry for commons-logging from start script.
@@ -120,5 +121,5 @@
The cl jar file name in the startup script also is no longer correct,
so remove it completely.
http://people.apache.org/~rjung/patches/remove_cl_from_cp.patch
- +1: rjung, kkolinko
+ +1: rjung, kkolinko, markt
-1:
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r790296 - /tomcat/current/tc5.5.x/STATUS.txt
Posted by Rainer Jung <ra...@kippdata.de>.
On 01.07.2009 22:03, Mark Thomas wrote:
> Rainer Jung wrote:
>> On 01.07.2009 20:14, markt@apache.org wrote:
>>> * Fix small memory leak found by find bugs.
>>> Backport of http://svn.apache.org/viewvc?view=rev&revision=717906 from tc6
>>> resp. http://svn.apache.org/viewvc?view=rev&revision=735645 from OACC.
>>> +1: rjung, kkolinko
>>> + +1: markt - patch does much more than fix a memory leak
>>> -1:
>> Yes, I wondered a bit too, but I took over the commit message and
>> changelog entry from your r717906 and r699634.
>>
>> I guess findbugs flagged it as a leak.
>>
>> Should we change the respective changelog entries?
>
> The current change logs look fine to me. My only point was that 735645
> covers two issues so your proposal in the status file should note both,
> as should the commit message when you apply this to 5.5.x
>
> I am happy with both fixes being back ported.
Ah, I understand. The commit only contains the simple one of the two
OACC fixes, the other one is one of the bigger patches not being
packported to tc 5.5 but somehow being risky and maybe not worth
applying to 5.5.x. I'll fix the commit message.
Regards,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r790296 - /tomcat/current/tc5.5.x/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
Rainer Jung wrote:
> On 01.07.2009 20:14, markt@apache.org wrote:
>> * Fix small memory leak found by find bugs.
>> Backport of http://svn.apache.org/viewvc?view=rev&revision=717906 from tc6
>> resp. http://svn.apache.org/viewvc?view=rev&revision=735645 from OACC.
>> +1: rjung, kkolinko
>> + +1: markt - patch does much more than fix a memory leak
>> -1:
>
> Yes, I wondered a bit too, but I took over the commit message and
> changelog entry from your r717906 and r699634.
>
> I guess findbugs flagged it as a leak.
>
> Should we change the respective changelog entries?
The current change logs look fine to me. My only point was that 735645
covers two issues so your proposal in the status file should note both,
as should the commit message when you apply this to 5.5.x
I am happy with both fixes being back ported.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r790296 - /tomcat/current/tc5.5.x/STATUS.txt
Posted by Rainer Jung <ra...@kippdata.de>.
On 01.07.2009 20:14, markt@apache.org wrote:
> * Fix small memory leak found by find bugs.
> Backport of http://svn.apache.org/viewvc?view=rev&revision=717906 from tc6
> resp. http://svn.apache.org/viewvc?view=rev&revision=735645 from OACC.
> +1: rjung, kkolinko
> + +1: markt - patch does much more than fix a memory leak
> -1:
Yes, I wondered a bit too, but I took over the commit message and
changelog entry from your r717906 and r699634.
I guess findbugs flagged it as a leak.
Should we change the respective changelog entries?
Regsrds,
Rainer
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org