You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "CrazyHZM (GitHub)" <gi...@apache.org> on 2019/03/01 03:17:25 UTC
[GitHub] [incubator-dubbo] CrazyHZM opened pull request #3581: fix
Invalid use of BasicClientConnManager: connection still allocated #3243
## What is the purpose of the change
Invalid use of BasicClientConnManager: connection still allocated #3243
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3581 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] ralf0131 closed pull request #3581:
[DUBBO-3243] Fix Invalid use of BasicClientConnManager: connection still
allocated #3243
Posted by "ralf0131 (GitHub)" <gi...@apache.org>.
[ pull request closed by ralf0131 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3581 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3581: fix
Invalid use of BasicClientConnManager: connection still allocated #3243
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=h1) Report
> Merging [#3581](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/c528d56b6e947fab85a6ec772ae50d0db2491cb2?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.6.x #3581 +/- ##
============================================
- Coverage 47.18% 47.13% -0.05%
+ Complexity 4396 4394 -2
============================================
Files 565 565
Lines 25084 25088 +4
Branches 4422 4422
============================================
- Hits 11835 11825 -10
- Misses 11426 11437 +11
- Partials 1823 1826 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ba/dubbo/rpc/protocol/hessian/HessianProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1oZXNzaWFuL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2hlc3NpYW4vSGVzc2lhblByb3RvY29sLmphdmE=) | `69.04% <100%> (+0.75%)` | `10 <0> (ø)` | :arrow_down: |
| [.../protocol/hessian/HttpClientConnectionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1oZXNzaWFuL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2hlc3NpYW4vSHR0cENsaWVudENvbm5lY3Rpb25GYWN0b3J5LmphdmE=) | `76.92% <100%> (+31.46%)` | `3 <1> (+1)` | :arrow_up: |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eVNlcnZlckhhbmRsZXIuamF2YQ==) | `72.22% <0%> (-11.12%)` | `6% <0%> (-1%)` | |
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `78.37% <0%> (-5.41%)` | `9% <0%> (ø)` | |
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `61.25% <0%> (-5%)` | `20% <0%> (-1%)` | |
| [...ba/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvbXVsdGljYXN0L011bHRpY2FzdFJlZ2lzdHJ5LmphdmE=) | `47.28% <0%> (-1.68%)` | `29% <0%> (ø)` | |
| [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `53.12% <0%> (-1.57%)` | `3% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=footer). Last update [c528d56...fbea748](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3581 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3581: fix
Invalid use of BasicClientConnManager: connection still allocated #3243
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=h1) Report
> Merging [#3581](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/c528d56b6e947fab85a6ec772ae50d0db2491cb2?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.6.x #3581 +/- ##
============================================
- Coverage 47.18% 47.13% -0.05%
+ Complexity 4396 4394 -2
============================================
Files 565 565
Lines 25084 25088 +4
Branches 4422 4422
============================================
- Hits 11835 11825 -10
- Misses 11426 11437 +11
- Partials 1823 1826 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ba/dubbo/rpc/protocol/hessian/HessianProtocol.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1oZXNzaWFuL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2hlc3NpYW4vSGVzc2lhblByb3RvY29sLmphdmE=) | `69.04% <100%> (+0.75%)` | `10 <0> (ø)` | :arrow_down: |
| [.../protocol/hessian/HttpClientConnectionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1oZXNzaWFuL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcnBjL3Byb3RvY29sL2hlc3NpYW4vSHR0cENsaWVudENvbm5lY3Rpb25GYWN0b3J5LmphdmE=) | `76.92% <100%> (+31.46%)` | `3 <1> (+1)` | :arrow_up: |
| [.../remoting/transport/netty4/NettyServerHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVtb3RpbmcvdHJhbnNwb3J0L25ldHR5NC9OZXR0eVNlcnZlckhhbmRsZXIuamF2YQ==) | `72.22% <0%> (-11.12%)` | `6% <0%> (-1%)` | |
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `83.33% <0%> (-5.56%)` | `6% <0%> (-1%)` | |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9jb25maWcvc3ByaW5nL2V4dGVuc2lvbi9TcHJpbmdFeHRlbnNpb25GYWN0b3J5LmphdmE=) | `78.37% <0%> (-5.41%)` | `9% <0%> (ø)` | |
| [...a/dubbo/remoting/transport/netty/NettyChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDaGFubmVsLmphdmE=) | `61.25% <0%> (-5%)` | `20% <0%> (-1%)` | |
| [...ba/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvbXVsdGljYXN0L011bHRpY2FzdFJlZ2lzdHJ5LmphdmE=) | `47.28% <0%> (-1.68%)` | `29% <0%> (ø)` | |
| [...bo/remoting/transport/netty/NettyCodecAdapter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3581/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDb2RlY0FkYXB0ZXIuamF2YQ==) | `53.12% <0%> (-1.57%)` | `3% <0%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=footer). Last update [c528d56...fbea748](https://codecov.io/gh/apache/incubator-dubbo/pull/3581?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3581 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org