You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "1330571 (via GitHub)" <gi...@apache.org> on 2023/03/08 06:25:26 UTC
[GitHub] [doris] 1330571 opened a new pull request, #17551: [fix](streamLoad)add missing field in beginTxn
1330571 opened a new pull request, #17551:
URL: https://github.com/apache/doris/pull/17551
# Proposed changes
Issue Number: close #xxx
## Problem summary
Add more fields defined in thrift but not use in beginTxn function
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [X] Is this PR support rollback (If NO, please explain WHY)
## Further comments
### MySQL bin
mysql> SET exec_mem_limit = 10000000;
Query OK, 0 rows affected (0.01 sec)
mysql> begin;
mysql> insert into example_tbl values (1,1);
mysql> insert into example_tbl values (2,2);
mysql> commit;
### Be Log
fragment_mgr.cpp:719] Register query/load memory tracker, query/load id: b2c4bfe09f0f4c03-925271683c000d53 limit: 9.54 MB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mymeiyi commented on a diff in pull request #17551: [fix](insert) Session varaiables dont work for transaction insert
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on code in PR #17551:
URL: https://github.com/apache/doris/pull/17551#discussion_r1132351799
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1486,7 +1486,9 @@ private void beginTxn(String dbName, String tblName) throws UserException, TExce
InterruptedException, ExecutionException, TimeoutException {
TransactionEntry txnEntry = context.getTxnEntry();
TTxnParams txnConf = txnEntry.getTxnConf();
- long timeoutSecond = ConnectContext.get().getExecTimeout();
+ SessionVariable sessionVariable = ConnectContext.get().getSessionVariable();
+ int timeoutSecond = sessionVariable.getQueryTimeoutS();
Review Comment:
timeout should keep the original logic, because getExecTimeout may be query_timeout or insert_timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17551: [fix](insert) Session varaiables dont work for transaction insert
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17551:
URL: https://github.com/apache/doris/pull/17551#issuecomment-1475077501
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #17551: [fix](streamLoad)add missing field in beginTxn
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #17551:
URL: https://github.com/apache/doris/pull/17551#issuecomment-1461145530
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 33.66 seconds
stream load tsv: 461 seconds loaded 74807831229 Bytes, about 154 MB/s
stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s
stream load orc: 74 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230309014925_clickbench_pr_111057.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17551: [fix](streamLoad)add missing field in beginTxn
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17551:
URL: https://github.com/apache/doris/pull/17551#issuecomment-1459624850
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #17551: [fix](insert) Session varaiables dont work for transaction insert
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #17551:
URL: https://github.com/apache/doris/pull/17551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17551: [fix](insert) Session varaiables dont work for transaction insert
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17551:
URL: https://github.com/apache/doris/pull/17551#issuecomment-1465552721
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17551: [fix](streamLoad)add missing field in beginTxn
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17551:
URL: https://github.com/apache/doris/pull/17551#issuecomment-1461125672
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on a diff in pull request #17551: [fix](insert) Session varaiables dont work for transaction insert
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on code in PR #17551:
URL: https://github.com/apache/doris/pull/17551#discussion_r1132391327
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -1486,7 +1486,9 @@ private void beginTxn(String dbName, String tblName) throws UserException, TExce
InterruptedException, ExecutionException, TimeoutException {
TransactionEntry txnEntry = context.getTxnEntry();
TTxnParams txnConf = txnEntry.getTxnConf();
- long timeoutSecond = ConnectContext.get().getExecTimeout();
+ SessionVariable sessionVariable = ConnectContext.get().getSessionVariable();
+ int timeoutSecond = sessionVariable.getQueryTimeoutS();
Review Comment:
resolved with a new commit, now I use `ConnectContext.get().getExecTimeout()` to handle timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17551: [fix](insert) Session varaiables dont work for transaction insert
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17551:
URL: https://github.com/apache/doris/pull/17551#issuecomment-1465602199
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17551: [fix](insert) Session varaiables dont work for transaction insert
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17551:
URL: https://github.com/apache/doris/pull/17551#issuecomment-1463776337
> Is it better to rename this PR to
>
> ```
> [fix](insert) Session varaiables donot work for transaction insert?
> ```
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] mymeiyi commented on pull request #17551: [fix](streamLoad)add missing field in beginTxn
Posted by "mymeiyi (via GitHub)" <gi...@apache.org>.
mymeiyi commented on PR #17551:
URL: https://github.com/apache/doris/pull/17551#issuecomment-1463772873
Is it better to rename this PR to [fix](insert) Session varaiables donot work for transaction insert?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17551: [fix](insert) Session varaiables dont work for transaction insert
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17551:
URL: https://github.com/apache/doris/pull/17551#issuecomment-1464883362
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] 1330571 commented on pull request #17551: [fix](insert) Session varaiables dont work for transaction insert
Posted by "1330571 (via GitHub)" <gi...@apache.org>.
1330571 commented on PR #17551:
URL: https://github.com/apache/doris/pull/17551#issuecomment-1465662477
run compile
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #17551: [fix](insert) Session varaiables dont work for transaction insert
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17551:
URL: https://github.com/apache/doris/pull/17551#issuecomment-1475077509
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org