You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/09 13:27:06 UTC

[GitHub] [arrow] kiszk commented on a change in pull request #7136: ARROW-8486: [C++] Fix arrow-utility-test's failures on big-endian platforms

kiszk commented on a change in pull request #7136:
URL: https://github.com/apache/arrow/pull/7136#discussion_r422495833



##########
File path: cpp/src/arrow/util/bpacking_default.h
##########
@@ -31,6 +31,7 @@ namespace internal {
 
 inline const uint32_t* unpack1_32(const uint32_t* in, uint32_t* out) {
   uint32_t inl = util::SafeLoad(in);
+  inl = arrow::BitUtil::ToLittleEndian(inl);

Review comment:
       The original code supports only little-endian platform.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org