You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/08/03 14:24:56 UTC

[GitHub] [ratis-thirdparty] adoroszlai opened a new pull request, #36: RATIS-1632. Upgrade gRPC to 1.48.1

adoroszlai opened a new pull request, #36:
URL: https://github.com/apache/ratis-thirdparty/pull/36

   ## What changes were proposed in this pull request?
   
   ~Upgrade gRPC to 1.48.0, Netty to 4.1.79 in Ratis Thirdparty.~
   Upgrade gRPC to 1.48.1.
   
   https://issues.apache.org/jira/browse/RATIS-1632
   
   ## How was this patch tested?
   
   Regular CI:
   ~https://github.com/adoroszlai/ratis-thirdparty/runs/7451209538?check_suite_focus=true~
   https://github.com/adoroszlai/ratis-thirdparty/runs/7654050988?check_suite_focus=true
   
   ~Ran Ratis unit tests with local build of Ratis Thirdparty.  `TestRaftReconfigurationWithGrpc` failed both with and without the change, otherwise OK.~
   - [ ]  (in progress) Ratis unit tests with local build of Ratis Thirdparty


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis-thirdparty] szetszwo commented on pull request #36: RATIS-1632. Upgrade gRPC to 1.48.0, Netty to 4.1.79

Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #36:
URL: https://github.com/apache/ratis-thirdparty/pull/36#issuecomment-1191736749

   @adoroszlai , why updating the versions?
   
   BTW, there is a recent gRPC "ByteBuffer memory leak in retry mechanism" issue; see https://github.com/grpc/grpc-java/issues/9340 .   I wonder if we should wait for it.
   
   See also https://lists.apache.org/thread/j7ovtqor4do39z4yfps0fvp3hhgncotn


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis-thirdparty] adoroszlai closed pull request #36: RATIS-1632. Upgrade gRPC to 1.48.0, Netty to 4.1.79

Posted by GitBox <gi...@apache.org>.
adoroszlai closed pull request #36: RATIS-1632. Upgrade gRPC to 1.48.0, Netty to 4.1.79
URL: https://github.com/apache/ratis-thirdparty/pull/36


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis-thirdparty] adoroszlai commented on pull request #36: RATIS-1632. Upgrade gRPC to 1.48.1

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #36:
URL: https://github.com/apache/ratis-thirdparty/pull/36#issuecomment-1204185099

   Thanks @szetszwo for reviewing and committing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis-thirdparty] adoroszlai commented on pull request #36: RATIS-1632. Upgrade gRPC to 1.48.0, Netty to 4.1.79

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #36:
URL: https://github.com/apache/ratis-thirdparty/pull/36#issuecomment-1191825200

   @szetszwo Sorry, I was under the impression that 4.1.77 has a CVE, but actually it is the one to fix the CVE.  So we can close this for now, waiting for gRPC with the fix for memleak.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis-thirdparty] szetszwo merged pull request #36: RATIS-1632. Upgrade gRPC to 1.48.1

Posted by GitBox <gi...@apache.org>.
szetszwo merged PR #36:
URL: https://github.com/apache/ratis-thirdparty/pull/36


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org