You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Max Bowsher <ma...@ukf.net> on 2004/08/03 12:49:54 UTC

[PATCH] apr-util apu-config update (was: RC5 is available)

David Reid wrote:
> The changes to the apr-find macro have NOT been picked up in apr-util
> and apr-iconv, so hopefully these tarballs will encourage people to fix
> that?

Here is the apr-util part of that. (apr-iconv part will follow later)

In addition to applying the equivalent changes from apr to apr-util, this
patch also brings across some forgotten comment updates and OS/2 compat code
from apr.

In particular, please could people look at the two "dnl Note: " paragraphs
in find_apu.m4 which this patch does _not_ touch. Copied here:

dnl Note: At this time, we cannot find *both* a source dir and a build dir.
dnl       If both are available, the build directory should be passed to
dnl       the --with-apr-util switch.

The fact that you can pass a build directory to the --with-apr(-util)
options seems to be one of those occasionally useful but not very tested
features. Perhaps we don't want to advertise it (yet?).

dnl Note: the installation layout is presumed to follow the standard
dnl       PREFIX/lib and PREFIX/include pattern. If the APU config file
dnl       is available (and can be found), then non-standard layouts are
dnl       possible, since it will be described in the config file.

Is plain wrong, I think. The macro *requires* that a config file be found.

Max.

Re: [PATCH] apr-util apu-config update (was: RC5 is available)

Posted by Justin Erenkrantz <ju...@erenkrantz.com>.
--On Tuesday, August 3, 2004 11:49 AM +0100 Max Bowsher <ma...@ukf.net> wrote:

> Here is the apr-util part of that. (apr-iconv part will follow later)
>
> In addition to applying the equivalent changes from apr to apr-util, this
> patch also brings across some forgotten comment updates and OS/2 compat code
> from apr.

Thanks!  There were a couple of typos (a 'dn' instead of 'do') and I also 
added the autoconf-2.13 changes (i.e. no m4_if, etc.).  -- justin