You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "poorbarcode (via GitHub)" <gi...@apache.org> on 2023/07/28 10:58:30 UTC

[GitHub] [pulsar] poorbarcode commented on a diff in pull request #20898: [fix] [ml] fix discontinuous ledger deletion

poorbarcode commented on code in PR #20898:
URL: https://github.com/apache/pulsar/pull/20898#discussion_r1277406409


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -2626,6 +2626,7 @@ void internalTrimLedgers(boolean isTruncate, CompletableFuture<?> promise) {
             }
 
             long slowestReaderLedgerId = -1;
+            long slowestNonDurationLedgerId = getTheSlowestNonDurationReadPosition().getLedgerId();

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org