You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/24 15:31:53 UTC

[GitHub] [incubator-yunikorn-k8shim] craigcondit opened a new pull request #396: [YUNIKORN-1144] Fix deadlock in context.getTask()

craigcondit opened a new pull request #396:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/396


   ### What is this PR for?
   Fixes deadlock introduced in context.getTask() after YUNIKORN-1102.
   
   ### What type of PR is it?
   * [x ] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-1144
   
   ### How should this be tested?
   Unit and e2e tests.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] craigcondit closed pull request #396: [YUNIKORN-1144] Fix deadlock in context.getTask()

Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #396:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/396


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-k8shim] craigcondit commented on pull request #396: [YUNIKORN-1144] Fix deadlock in context.getTask()

Posted by GitBox <gi...@apache.org>.
craigcondit commented on pull request #396:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/396#issuecomment-1077794911


   Did not see that pre-commit checks did not run for this one before merging. I have run e2e tests locally after merge to verify functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org