You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/29 18:38:39 UTC

[GitHub] [superset] betodealmeida commented on a diff in pull request #20895: fix: make a new entrypoint for deprecated postgres dialect

betodealmeida commented on code in PR #20895:
URL: https://github.com/apache/superset/pull/20895#discussion_r933531169


##########
setup.py:
##########
@@ -64,6 +64,9 @@ def get_git_sha() -> str:
     zip_safe=False,
     entry_points={
         "console_scripts": ["superset=superset.cli.main:superset"],
+        "sqlalchemy.dialects": [

Review Comment:
   ```suggestion
           # the `postgres+psycopy2://` scheme was removed in SQLAlchemy 1.4, add an alias here
           # to prevent breaking existing databases
           "sqlalchemy.dialects": [
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org