[jira] Commented: (OFBIZ-1222) Improvements while creating invoice for order

["Jacopo Cappellato (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527708 ] 

Jacopo Cappellato commented on OFBIZ-1222:
------------------------------------------

I don't know anything about the second issue in your list but about the first one: are we sure that it is an oustanding bug? Could you please help to recreate the issue in the demo server:
https://demo.hotwaxmedia.com/ordermgr/control/main

?


> Improvements while creating invoice for order
> ---------------------------------------------
>
>                 Key: OFBIZ-1222
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1222
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: accounting
>            Reporter: Rashko Rejmer
>            Priority: Minor
>         Attachments: InvoiceServices.patch
>
>
> I have made patch that adds 2 improvements to the InvoiceServices.createInvoiceForOrder service:
>   - this method doesn't checks if the billItems Map contains already invoiced items. This is not visible through the UI. In all places where this service is invoked they are passed not invoiced order items. This improvement will prevent double invoicing if only part of one order item was invoiced and we try to invoice the second part(e.g if we bought 5 x GZ-1000 products and we invoice only 2 of them, then we try to invoice the rest - 3);
>   - now quantities of rental order items are calculated correctly. If one order items rents fixed asset for 2 days the quantity of the invoice item should be multiplied by 2. The same is valid for adjustment quantities for additional charges for second and n-th person;
>   - some cleanups - variables that are not used any more;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.