You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Peter Kriens (JIRA)" <ji...@apache.org> on 2009/02/18 09:25:01 UTC
[jira] Created: (FELIX-946) Code for new OSGi TSL proposal
Code for new OSGi TSL proposal
------------------------------
Key: FELIX-946
URL: https://issues.apache.org/jira/browse/FELIX-946
Project: Felix
Issue Type: New Feature
Reporter: Peter Kriens
Assignee: Marcel Offermans
Priority: Trivial
Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-946) Code for new OSGi TSL proposal
Posted by "Peter Kriens (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Kriens updated FELIX-946:
-------------------------------
Attachment: shell.zip
> Code for new OSGi TSL proposal
> ------------------------------
>
> Key: FELIX-946
> URL: https://issues.apache.org/jira/browse/FELIX-946
> Project: Felix
> Issue Type: New Feature
> Reporter: Peter Kriens
> Assignee: Marcel Offermans
> Priority: Trivial
> Attachments: shell.zip
>
>
> Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-946) Code for new OSGi TSL proposal
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718663#action_12718663 ]
Richard S. Hall commented on FELIX-946:
---------------------------------------
Thanks. I will try to get to the patch when the ICLA is recorded.
> Code for new OSGi TSL proposal
> ------------------------------
>
> Key: FELIX-946
> URL: https://issues.apache.org/jira/browse/FELIX-946
> Project: Felix
> Issue Type: New Feature
> Reporter: Peter Kriens
> Assignee: Marcel Offermans
> Priority: Trivial
> Attachments: dwb.patch.gz, shell.zip
>
>
> Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FELIX-946) Code for new OSGi TSL proposal
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet closed FELIX-946.
---------------------------------
Resolution: Fixed
Closing this issue since the code has been imported and patch applied.
I've created a gogo component to raise issue for this specific component.
> Code for new OSGi TSL proposal
> ------------------------------
>
> Key: FELIX-946
> URL: https://issues.apache.org/jira/browse/FELIX-946
> Project: Felix
> Issue Type: New Feature
> Components: Gogo
> Reporter: Peter Kriens
> Assignee: Marcel Offermans
> Priority: Trivial
> Attachments: dwb.patch.gz, shell.zip
>
>
> Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-946) Code for new OSGi TSL proposal
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12718535#action_12718535 ]
Richard S. Hall commented on FELIX-946:
---------------------------------------
I have committed the initial contribution of the OSGi shell to our repository under the name "gogo" for the time being. It still needs to have its packages renamed and be put into the proper subproject structure.
I was thinking that before we do that, that if Derek wants to supply his patches, we can apply those first. Derek, I assume these are all small patches, but given the number of them it might be nice if you have an ICLA on file. Do you? If so, could you attach a patch to this issue?
> Code for new OSGi TSL proposal
> ------------------------------
>
> Key: FELIX-946
> URL: https://issues.apache.org/jira/browse/FELIX-946
> Project: Felix
> Issue Type: New Feature
> Reporter: Peter Kriens
> Assignee: Marcel Offermans
> Priority: Trivial
> Attachments: shell.zip
>
>
> Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-946) Code for new OSGi TSL proposal
Posted by "Richard S. Hall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12713019#action_12713019 ]
Richard S. Hall commented on FELIX-946:
---------------------------------------
We are working on getting this into SVN, we need to go through IP clearance. Hopefully, this will all be done in a week or so, then we can move forward with patches. I think we will need to rename some packages and whatnot. Perhaps we should apply the patches before doing so.
> Code for new OSGi TSL proposal
> ------------------------------
>
> Key: FELIX-946
> URL: https://issues.apache.org/jira/browse/FELIX-946
> Project: Felix
> Issue Type: New Feature
> Reporter: Peter Kriens
> Assignee: Marcel Offermans
> Priority: Trivial
> Attachments: shell.zip
>
>
> Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-946) Code for new OSGi TSL proposal
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722632#action_12722632 ]
Guillaume Nodet commented on FELIX-946:
---------------------------------------
The ICLA is on file, so I'll go ahead an apply the patch.
> Code for new OSGi TSL proposal
> ------------------------------
>
> Key: FELIX-946
> URL: https://issues.apache.org/jira/browse/FELIX-946
> Project: Felix
> Issue Type: New Feature
> Reporter: Peter Kriens
> Assignee: Marcel Offermans
> Priority: Trivial
> Attachments: dwb.patch.gz, shell.zip
>
>
> Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-946) Code for new OSGi TSL proposal
Posted by "Peter Kriens (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712876#action_12712876 ]
Peter Kriens commented on FELIX-946:
------------------------------------
MD5 Checksum 9de77d0fef4caff5bb2cf3943a224e98
> Code for new OSGi TSL proposal
> ------------------------------
>
> Key: FELIX-946
> URL: https://issues.apache.org/jira/browse/FELIX-946
> Project: Felix
> Issue Type: New Feature
> Reporter: Peter Kriens
> Assignee: Marcel Offermans
> Priority: Trivial
> Attachments: shell.zip
>
>
> Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-946) Code for new OSGi TSL proposal
Posted by "Derek Baum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Derek Baum updated FELIX-946:
-----------------------------
Attachment: dwb.patch.gz
attached patches mentioned in my previous comment.
The patch was created by copying my changes over a fresh checkout of http://svn.apache.org/repos/asf/felix/trunk/gogo and then running 'svn diff'.
The patched files are also annotated with my name 'derek' and the DWBx bug numbers mentioned in previous comment.
I have just submitted my ICLA to secretary@apache.org
> Code for new OSGi TSL proposal
> ------------------------------
>
> Key: FELIX-946
> URL: https://issues.apache.org/jira/browse/FELIX-946
> Project: Felix
> Issue Type: New Feature
> Reporter: Peter Kriens
> Assignee: Marcel Offermans
> Priority: Trivial
> Attachments: dwb.patch.gz, shell.zip
>
>
> Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-946) Code for new OSGi TSL proposal
Posted by "Derek Baum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12712903#action_12712903 ]
Derek Baum commented on FELIX-946:
----------------------------------
I have been working with this code and have made several bug fixes:
I can supply these as a diff against shell.zip attached to this issue, or when the code is loaded in SVN, I could raise issues against each of the bugs.
Here is a brief list of the fixes I've made:
./aQute/shell/osgi/OSGiCommands.java: // DWB1: osgi:each too verbose (formats results to System.out)
./aQute/shell/osgi/OSGiCommands.java: // DWB2: ClassNotFoundException should be caught in convert() method
./aQute/shell/osgi/OSGiShell.java: // DWB3: dynamically load optional framework components to reduce dependencies
./aQute/shell/osgi/OSGiShell.java: // DWB4: get() with trailing colon causes org.osgi.framework.InvalidSyntaxException
./aQute/shell/runtime/Closure.java: // DWB5: session.err is not redirected when creating pipeline
./aQute/shell/runtime/Closure.java: // DWB6: add 'set -x' trace feature if echo is set
./aQute/shell/runtime/Closure.java: // DWB7: removing variable via 'execute("name=") throws OutOfBoundsException
./aQute/shell/runtime/CommandSessionImpl.java: // DWB8: throw IllegatlStateException if session used after closed (as per rfc132)
./aQute/shell/runtime/CommandSessionImpl.java: // DWB9: there is no API to list all variables: https://www.osgi.org/bugzilla/show_bug.cgi?id=49
./aQute/shell/runtime/CommandSessionImpl.java: // DWB10: add SCOPE support: https://www.osgi.org/bugzilla/show_bug.cgi?id=51
./aQute/shell/runtime/CommandShellImpl.java: // DWB11: add removeCommand: https://www.osgi.org/bugzilla/show_bug.cgi?id=49
./aQute/shell/runtime/CommandShellImpl.java: // DWB12: there is no API to list commands: https://www.osgi.org/bugzilla/show_bug.cgi?id=49
./aQute/shell/runtime/CommandShellImpl.java: // DWB13: addCommand() fails to add static methods (if target is Class)
./aQute/shell/runtime/Parser.java: // DWB14: parser loops if // comment at start of program
./aQute/shell/runtime/Parser.java: // DWB15: allow program to have trailing ';'
./aQute/shell/runtime/Pipe.java: // DWB16: redirect System.err when creating pipe
./aQute/shell/runtime/Reflective.java: // DWB16: coerce() doesn't support static methods
./aQute/shell/runtime/Reflective.java: // DWB17: coerce() doesn't support static void main(String[]) in rfc132
./aQute/shell/runtime/Reflective.java: // DWB18: coerce() doesn't extract cause from InvocationTargetException
./aQute/shell/runtime/Reflective.java: // DWB19: coerce() won't add empty array to satisfy Object[] argument
./aQute/threadio/ThreadIOImpl.java: // DWB20: ThreadIO should check and reset IO if something (e.g. jetty) overrides
> Code for new OSGi TSL proposal
> ------------------------------
>
> Key: FELIX-946
> URL: https://issues.apache.org/jira/browse/FELIX-946
> Project: Felix
> Issue Type: New Feature
> Reporter: Peter Kriens
> Assignee: Marcel Offermans
> Priority: Trivial
> Attachments: shell.zip
>
>
> Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FELIX-946) Code for new OSGi TSL proposal
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet updated FELIX-946:
----------------------------------
Component/s: Gogo
> Code for new OSGi TSL proposal
> ------------------------------
>
> Key: FELIX-946
> URL: https://issues.apache.org/jira/browse/FELIX-946
> Project: Felix
> Issue Type: New Feature
> Components: Gogo
> Reporter: Peter Kriens
> Assignee: Marcel Offermans
> Priority: Trivial
> Attachments: dwb.patch.gz, shell.zip
>
>
> Source code donation for the OSGi Shell proposal
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.