You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2023/01/11 22:54:30 UTC
[GitHub] [arrow] assignUser opened a new pull request, #33620: GH-33619 : [Documentation] Update PR template
assignUser opened a new pull request, #33620:
URL: https://github.com/apache/arrow/pull/33620
# Rationale for this change
I will keep this as a draft for now please feel free to suggest additional changes!
# What changes are included in this PR?
I have switched to smaller headers for now and removed the first head + closes keyword to avoid redundancy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #33620: GH-33619: [Documentation] Update PR template
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #33620:
URL: https://github.com/apache/arrow/pull/33620#issuecomment-1379586344
:warning: GitHub issue #33619 **has no components**, please add labels for components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #33620: GH-33619: [Documentation] Update PR template
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #33620:
URL: https://github.com/apache/arrow/pull/33620#issuecomment-1384110916
Benchmark runs are scheduled for baseline = 7d3bca39708aa7834cfe48e6a6abc607d1cf8c6f and contender = 7e6bcd1bd7d8b3f7da39098d80881ef4f3b1d765. 7e6bcd1bd7d8b3f7da39098d80881ef4f3b1d765 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0b8b0821932540acbb4898104150c8f5...47526d65588b4c4e833fbf284a2258b3/)
[Finished :arrow_down:0.39% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d72b234beedb43109f0c635e6f3f5467...69d2c0ff1e2b43dd9ca4519665e487b1/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/180cc9a49f4344a19a600f5f72b1c60c...c85767e045884957951a018bdb5a6139/)
[Finished :arrow_down:0.22% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8decaa58ddc3460a8666f2634ba6d0da...931a9ce15397431c9d254aff51200187/)
Buildkite builds:
[Finished] [`7e6bcd1b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2191)
[Finished] [`7e6bcd1b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2214)
[Finished] [`7e6bcd1b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2186)
[Finished] [`7e6bcd1b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2207)
[Finished] [`7d3bca39` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2190)
[Finished] [`7d3bca39` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2213)
[Finished] [`7d3bca39` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2185)
[Finished] [`7d3bca39` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2206)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on a diff in pull request #33620: GH-33619: [Documentation] Update PR template
Posted by GitBox <gi...@apache.org>.
wjones127 commented on code in PR #33620:
URL: https://github.com/apache/arrow/pull/33620#discussion_r1069845277
##########
.github/pull_request_template.md:
##########
@@ -50,7 +48,7 @@ We typically require tests for all PRs in order to:
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
-# Are there any user-facing changes?
+### Are there any user-facing changes?
Review Comment:
Another piece of feedback:
1. The `breaking-change` label didn't exist. I decided to add it as `Breaking Change` just now, since there isn't a good reason to kebab-case AFAIK.
2. I don't think non-committers can apply labels, right? So perhaps the instructions simply need to have a checkbox `[ ] This PR contains breaking changes` or something like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #33620: GH-33619: [Documentation] Update PR template
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #33620:
URL: https://github.com/apache/arrow/pull/33620#issuecomment-1379586318
:warning: GitHub issue #33619 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #33620: GH-33619: [Documentation] Update PR template
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on PR #33620:
URL: https://github.com/apache/arrow/pull/33620#issuecomment-1383702537
Whoops, sorry, the linter was failing on the code line in archery .. This will be fixed by https://github.com/apache/arrow/pull/15067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on a diff in pull request #33620: GH-33619: [Documentation] Update PR template
Posted by GitBox <gi...@apache.org>.
wjones127 commented on code in PR #33620:
URL: https://github.com/apache/arrow/pull/33620#discussion_r1069999047
##########
.github/pull_request_template.md:
##########
@@ -50,7 +48,7 @@ We typically require tests for all PRs in order to:
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
-# Are there any user-facing changes?
+### Are there any user-facing changes?
Review Comment:
Actually, I'll handle this in #33660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #33620: GH-33619: [Documentation] Update PR template
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on PR #33620:
URL: https://github.com/apache/arrow/pull/33620#issuecomment-1379955098
> Following up on the discussion about stripping comments from the pull request description when merging, I believe adding the following around [line 583 of merge_arrow_pr.py](https://github.com/apache/arrow/blob/c287cfe3cf384bd8b9faf1a52d439b902a457f8d/dev/merge_arrow_pr.py#L583) should work:
Short term that would be good to do to avoid those long noisy commit messages. Longer term, IMO we should discuss using only the title of the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #33620: GH-33619: [Documentation] Update PR template
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #33620:
URL: https://github.com/apache/arrow/pull/33620#issuecomment-1379586277
* Closes: #33619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kevingurney commented on pull request #33620: GH-33619: [Documentation] Update PR template
Posted by GitBox <gi...@apache.org>.
kevingurney commented on PR #33620:
URL: https://github.com/apache/arrow/pull/33620#issuecomment-1379702386
Looks good to me! Thanks for making this change, @assignUser!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche merged pull request #33620: GH-33619: [Documentation] Update PR template
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche merged PR #33620:
URL: https://github.com/apache/arrow/pull/33620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org