[GitHub] [accumulo] milleruntime commented on pull request #1752: New unload thrift endpoint. Closes #1750

[GitBox <gi...@apache.org>]

milleruntime commented on pull request #1752:
URL: https://github.com/apache/accumulo/pull/1752#issuecomment-716658357


   > It looks like the only action of this PR is to replace an enum type with a String type. I don't see the advantage of that. Concrete types gives us safety and prevent bugs. It is normal for us to have Thrift-type and a non-Thrift-type that we have to convert between, in order to avoid leaking Thrift types into our code. I'm not sure it's better to replace concrete types with String to avoid that redundancy.
   
   The motivation for this change was to help with cleaning up all the enums in Master code.  I wasn't thrilled about this change, when I saw all that was required to remove the thrift enum.  I will close this for now and try to clean up the code without having to change the Thrift endpoint.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org