You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2015/11/03 19:00:14 UTC
Review Request 39909: HIVE-12320
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39909/
-----------------------------------------------------------
Review request for hive and Jason Dere.
Bugs: HIVE-12320
https://issues.apache.org/jira/browse/HIVE-12320
Repository: hive-git
Description
-------
hive.metastore.disallow.incompatible.col.type.changes should be true by default
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3ab73ad
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java bbaa1ce
ql/src/test/queries/clientpositive/avro_partitioned.q a06e7c4
ql/src/test/queries/clientpositive/input3.q 2efa7a4
ql/src/test/queries/clientpositive/orc_int_type_promotion.q 4a805a0
ql/src/test/queries/clientpositive/parquet_schema_evolution.q af0cf99
Diff: https://reviews.apache.org/r/39909/diff/
Testing
-------
Existing test suite.
Thanks,
Ashutosh Chauhan
Re: Review Request 39909: HIVE-12320
Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39909/#review105013
-----------------------------------------------------------
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java (line 841)
<https://reviews.apache.org/r/39909/#comment163375>
Nit: maybe we should get rid of those trailing spaces/tabs.
- Xuefu Zhang
On Nov. 3, 2015, 10:14 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39909/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 10:14 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-12320
> https://issues.apache.org/jira/browse/HIVE-12320
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> hive.metastore.disallow.incompatible.col.type.changes should be true by default
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3ab73ad
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java bbaa1ce
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java de8e98c
> ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 3a6535b
> ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java 068bdee
> ql/src/test/queries/clientpositive/avro_partitioned.q a06e7c4
> ql/src/test/queries/clientpositive/input3.q 2efa7a4
> ql/src/test/queries/clientpositive/orc_int_type_promotion.q 4a805a0
> ql/src/test/queries/clientpositive/parquet_schema_evolution.q af0cf99
> serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java a4323d1
>
> Diff: https://reviews.apache.org/r/39909/diff/
>
>
> Testing
> -------
>
> Existing test suite.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>
Re: Review Request 39909: HIVE-12320
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39909/
-----------------------------------------------------------
(Updated Nov. 4, 2015, 12:38 a.m.)
Review request for hive and Jason Dere.
Changes
-------
Removed ws changes.
Bugs: HIVE-12320
https://issues.apache.org/jira/browse/HIVE-12320
Repository: hive-git
Description
-------
hive.metastore.disallow.incompatible.col.type.changes should be true by default
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3ab73ad
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java bbaa1ce
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java de8e98c
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 3a6535b
ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java 068bdee
ql/src/test/queries/clientpositive/avro_partitioned.q a06e7c4
ql/src/test/queries/clientpositive/input3.q 2efa7a4
ql/src/test/queries/clientpositive/orc_int_type_promotion.q 4a805a0
ql/src/test/queries/clientpositive/parquet_schema_evolution.q af0cf99
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 24361c7
Diff: https://reviews.apache.org/r/39909/diff/
Testing
-------
Existing test suite.
Thanks,
Ashutosh Chauhan
Re: Review Request 39909: HIVE-12320
Posted by Ashutosh Chauhan <ha...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39909/
-----------------------------------------------------------
(Updated Nov. 3, 2015, 10:14 p.m.)
Review request for hive and Jason Dere.
Changes
-------
Addressed Jason's feedback.
Bugs: HIVE-12320
https://issues.apache.org/jira/browse/HIVE-12320
Repository: hive-git
Description
-------
hive.metastore.disallow.incompatible.col.type.changes should be true by default
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3ab73ad
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java bbaa1ce
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java de8e98c
ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 3a6535b
ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java 068bdee
ql/src/test/queries/clientpositive/avro_partitioned.q a06e7c4
ql/src/test/queries/clientpositive/input3.q 2efa7a4
ql/src/test/queries/clientpositive/orc_int_type_promotion.q 4a805a0
ql/src/test/queries/clientpositive/parquet_schema_evolution.q af0cf99
serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java a4323d1
Diff: https://reviews.apache.org/r/39909/diff/
Testing
-------
Existing test suite.
Thanks,
Ashutosh Chauhan
Re: Review Request 39909: HIVE-12320
Posted by Ashutosh Chauhan <ha...@apache.org>.
> On Nov. 3, 2015, 7:02 p.m., Jason Dere wrote:
> > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java, line 648
> > <https://reviews.apache.org/r/39909/diff/1/?file=1114773#file1114773line648>
> >
> > Is this method basically saying that all primitive types are compatible with each other? This does not seem like a valid assumption to me - should we be using FunctionRegistry.implicitConvertible() or something similar?
I was trying to maintain original logic which allows such conversions. But you are right, we should not allow those conversions.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39909/#review104949
-----------------------------------------------------------
On Nov. 3, 2015, 6 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39909/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 6 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-12320
> https://issues.apache.org/jira/browse/HIVE-12320
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> hive.metastore.disallow.incompatible.col.type.changes should be true by default
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3ab73ad
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java bbaa1ce
> ql/src/test/queries/clientpositive/avro_partitioned.q a06e7c4
> ql/src/test/queries/clientpositive/input3.q 2efa7a4
> ql/src/test/queries/clientpositive/orc_int_type_promotion.q 4a805a0
> ql/src/test/queries/clientpositive/parquet_schema_evolution.q af0cf99
>
> Diff: https://reviews.apache.org/r/39909/diff/
>
>
> Testing
> -------
>
> Existing test suite.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>
Re: Review Request 39909: HIVE-12320
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39909/#review104949
-----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java (line 648)
<https://reviews.apache.org/r/39909/#comment163302>
Is this method basically saying that all primitive types are compatible with each other? This does not seem like a valid assumption to me - should we be using FunctionRegistry.implicitConvertible() or something similar?
- Jason Dere
On Nov. 3, 2015, 6 p.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39909/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2015, 6 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-12320
> https://issues.apache.org/jira/browse/HIVE-12320
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> hive.metastore.disallow.incompatible.col.type.changes should be true by default
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 3ab73ad
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java bbaa1ce
> ql/src/test/queries/clientpositive/avro_partitioned.q a06e7c4
> ql/src/test/queries/clientpositive/input3.q 2efa7a4
> ql/src/test/queries/clientpositive/orc_int_type_promotion.q 4a805a0
> ql/src/test/queries/clientpositive/parquet_schema_evolution.q af0cf99
>
> Diff: https://reviews.apache.org/r/39909/diff/
>
>
> Testing
> -------
>
> Existing test suite.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>