You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/29 23:40:25 UTC
[GitHub] [airflow] kaxil opened a new pull request #13377: Bugfix: Sync Access Control defined in DAGs when running sync-perm
kaxil opened a new pull request #13377:
URL: https://github.com/apache/airflow/pull/13377
fixes https://github.com/apache/airflow/issues/13376
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on a change in pull request #13377: Bugfix: Sync Access Control defined in DAGs when running sync-perm
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on a change in pull request #13377:
URL: https://github.com/apache/airflow/pull/13377#discussion_r550033166
##########
File path: tests/cli/commands/test_sync_perm_command.py
##########
@@ -51,6 +56,7 @@ def test_cli_sync_perm(self, dagbag_mock, mock_cached_app):
assert appbuilder.sm.sync_roles.call_count == 1
dagbag_mock.assert_called_once_with(read_dags_from_db=True)
+ collect_dags_from_db_mock.assert_called_once_with()
Review comment:
nit: better to use `.assert_called_once()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13377: Bugfix: Sync Access Control defined in DAGs when running sync-perm
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13377:
URL: https://github.com/apache/airflow/pull/13377#issuecomment-752362648
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13377: Bugfix: Sync Access Control defined in DAGs when running sync-perm
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13377:
URL: https://github.com/apache/airflow/pull/13377
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13377: Bugfix: Sync Access Control defined in DAGs when running sync-perm
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13377:
URL: https://github.com/apache/airflow/pull/13377#discussion_r550163725
##########
File path: tests/cli/commands/test_sync_perm_command.py
##########
@@ -51,6 +56,7 @@ def test_cli_sync_perm(self, dagbag_mock, mock_cached_app):
assert appbuilder.sm.sync_roles.call_count == 1
dagbag_mock.assert_called_once_with(read_dags_from_db=True)
+ collect_dags_from_db_mock.assert_called_once_with()
Review comment:
Does not matter much tbh, `assert_called_once_with()` is a superset of `assert_called_once`, in this case it just checks that it is called with no args.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org