[GitHub] [spark] Ngone51 commented on issue #27943: [SPARK-31179] Fast fail the connection while last connection failed in the last retry IO wait

[GitBox <gi...@apache.org>]

Ngone51 commented on issue #27943: [SPARK-31179] Fast fail the connection while last connection failed in the last retry IO wait
URL: https://github.com/apache/spark/pull/27943#issuecomment-601040166
 
 
   > How about that, if the last connection failed in the last retry io wait, the new connection would be break but its retry count would not increase.
   
   So here, you don't want to reduce the connection chances for the request/task in case of it may could establish connection successfully without giving up connecting within ioRetryWait?
   
   If so,  I think it can be a valid concern but really make things complicate and I'm wondering if it's worth to do so.
   
   And at least, as per @tgravescs comment, I think we should record the failed time for the whole `ClientPool` instead of every client from the same `ClientPool`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org