You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/23 02:00:34 UTC
[GitHub] [kafka] ableegoldman opened a new pull request #11113: KAFKA-13128: wait for all keys to be fully processed in #shouldQueryStoresAfterAddingAndRemovingStreamThread
ableegoldman opened a new pull request #11113:
URL: https://github.com/apache/kafka/pull/11113
This test is flaky due to waiting on all records to be processed for only a single key before issuing IQ lookups and asserting whether data was found. See [this comment](https://issues.apache.org/jira/browse/KAFKA-13128?focusedCommentId=17385841&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17385841) for full analysis on how this happened
Should be cherrypicked to 3.0 (test fix to help stabilize the build @kkonstantine ) and to 2.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11113: KAFKA-13128: wait for all keys to be fully processed in #shouldQueryStoresAfterAddingAndRemovingStreamThread
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11113:
URL: https://github.com/apache/kafka/pull/11113#issuecomment-885922477
@wcarlson5 yeah I think we can flesh this test out even more, but I'm going to merge this fix for now so we can help stabilize the 3.0 release branch (and because we actually got a fully green build for once 🥳 )
Maybe one of us can just tack that on to some other small PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11113: KAFKA-13128: wait for all keys to be fully processed in #shouldQueryStoresAfterAddingAndRemovingStreamThread
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11113:
URL: https://github.com/apache/kafka/pull/11113#issuecomment-885952042
Merged to trunk and cherrypicked back to 2.8 and 3.0 (test fix @kkonstantine )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #11113: KAFKA-13128: wait for all keys to be fully processed in #shouldQueryStoresAfterAddingAndRemovingStreamThread
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #11113:
URL: https://github.com/apache/kafka/pull/11113#issuecomment-885356922
cc @PhilHardwick @cadonna @wcarlson5 @lct45 @vvcephei
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] PhilHardwick commented on pull request #11113: KAFKA-13128: wait for all keys to be fully processed in #shouldQueryStoresAfterAddingAndRemovingStreamThread
Posted by GitBox <gi...@apache.org>.
PhilHardwick commented on pull request #11113:
URL: https://github.com/apache/kafka/pull/11113#issuecomment-885481831
Thank so much for fixing this - your change is what I had intended for this test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11113: KAFKA-13128: wait for all keys to be fully processed in #shouldQueryStoresAfterAddingAndRemovingStreamThread
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11113:
URL: https://github.com/apache/kafka/pull/11113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org