You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "kazuyukitanimura (via GitHub)" <gi...@apache.org> on 2025/07/10 22:29:32 UTC
[I] Add date_format support [datafusion-comet]
kazuyukitanimura opened a new issue, #2014:
URL: https://github.com/apache/datafusion-comet/issues/2014
### What is the problem the feature request solves?
date_format is not supported
https://spark.apache.org/docs/latest/api/python/reference/pyspark.sql/api/pyspark.sql.functions.date_format.html
### Describe the potential solution
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add date_format support [datafusion-comet]
Posted by "parthchandra (via GitHub)" <gi...@apache.org>.
parthchandra commented on issue #2014:
URL: https://github.com/apache/datafusion-comet/issues/2014#issuecomment-3071490917
[CastOptions](https://github.com/apache/datafusion-comet/blob/76cf5af9818ee8a56b4e4b2548ac2d5f35a0fff4/native/spark-expr/src/conversion_funcs/cast.rs#L65) has a `FormatOptions` field that you might want to look at while implementing this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add date_format support [datafusion-comet]
Posted by "kazuyukitanimura (via GitHub)" <gi...@apache.org>.
kazuyukitanimura commented on issue #2014:
URL: https://github.com/apache/datafusion-comet/issues/2014#issuecomment-6132468918
Thanks @dwsmith1983
I guess there are still unsupported formats if I understand correctly.
Should we open a separate tickets for them or we can keep using this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add date_format support [datafusion-comet]
Posted by "jatin510 (via GitHub)" <gi...@apache.org>.
jatin510 commented on issue #2014:
URL: https://github.com/apache/datafusion-comet/issues/2014#issuecomment-3060316382
i would love to work on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add date_format support [datafusion-comet]
Posted by "dwsmith1983 (via GitHub)" <gi...@apache.org>.
dwsmith1983 commented on issue #2014:
URL: https://github.com/apache/datafusion-comet/issues/2014#issuecomment-5637500033
`date_format` is supported since #3201 (68f127b75). `CometDateFormat` in spark/src/main/scala/org/apache/comet/serde/datetime.scala maps the common literal formats to DataFusion's `to_char` natively and routes every other format or timezone combination through the codegen dispatcher, so the expression runs inside the Comet pipeline in all cases; docs/source/user-guide/latest/expressions.md lists it as supported (Hybrid). Suggest closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add date_format support [datafusion-comet]
Posted by "dwsmith1983 (via GitHub)" <gi...@apache.org>.
dwsmith1983 commented on issue #2014:
URL: https://github.com/apache/datafusion-comet/issues/2014#issuecomment-5976750820
Gentle ping: still holds on current main. `date_format` is supported since #3201 (native for common formats, codegen dispatch otherwise), with `date_format*.sql` tests. OK to close?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org