You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by Paritosh Ranjan <pr...@xebia.com> on 2011/11/01 04:51:11 UTC

Re: Patch : Formatting

Got it, Thanks.

On 31-10-2011 23:05, Grant Ingersoll wrote:
> At the bottom of the HowToContribute pages, there should be links to Eclipse and IntelliJ codestyle formatters.
>
> On Oct 31, 2011, at 12:21 PM, Manuel Blechschmidt wrote:
>
>> Hi Paritosh,
>>
>>> Hi,
>>>
>>> How can I submit the patch in the format used by Mahout? I can't find anything on this on the "How to Contribute" Page.
>> ...
>> But take care about the following points
>>
>> 	• All public classes and methods should have informative Javadoc comments. http://java.sun.com/j2se/javadoc/writingdoccomments/
>> 	• Code should be formatted according to Sun's conventions (http://java.sun.com/docs/codeconv/), with one exception:
>>         	• indent two spaces per level, not four.
>> 	• Contributions should pass existing unit tests.
>> 	• New unit tests (http://www.junit.org/) should be provided to demonstrate bugs and fixes.
>> ...
>> https://cwiki.apache.org/MAHOUT/how-to-contribute.html
>>
>> On 31.10.2011, at 17:00, Paritosh Ranjan wrote:
>>
>>> I use eclipse as IDE and generally I format my code using a formatter.xml, but I don't find formatter.xml in Mahout.
>> So you only have to set the formatting style go:  Java Convention and use 2 spaces instead of tabs.
>>
>>> Can someone help me?
>> After doing this you can create a JIRA issue and attach the formatter.xml for everybody else to use.
>> https://issues.apache.org/jira/browse/MAHOUT
>>
>>
>> Further here is a patch checklist:
>> https://cwiki.apache.org/confluence/display/MAHOUT/Patch+Check+List
>>
>>> Thanks and Regards,
>>> Paritosh
>> /Manuel
> --------------------------------------------
> Grant Ingersoll
> http://www.lucidimagination.com
>
>
>
>
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 10.0.1411 / Virus Database: 2092/3986 - Release Date: 10/31/11
>