[jira] [Commented] (SOLR-3301) Migrate enable/disable Ping from JSP to PingRequestHandler

["Matt Overstreet (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-3301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245934#comment-13245934 ] 

Matt Overstreet commented on SOLR-3301:
---------------------------------------

Let me know if you have any thoughts on the UI elements I've added.  I also refactored the admin css a bit to support using dd and dt with the same style as the statistics panel, but in other place in the admin.


                
> Migrate enable/disable Ping from JSP to PingRequestHandler
> ----------------------------------------------------------
>
>                 Key: SOLR-3301
>                 URL: https://issues.apache.org/jira/browse/SOLR-3301
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.0
>            Reporter: Eric Pugh
>             Fix For: 4.0
>
>         Attachments: PingRequestHandlerTest.java, healthcheck-ui.png, healthcheckenable.patch, ping_request_handler.patch
>
>
> My colleague @omnifroodle and I noticed that you can't enable/disable pings in 4.0 because action.jsp doesn't run.  This patch attaches the functionality to the PingRequestHandler.  We debated creating a new HealthcheckRequestHandler as well.   We added some basic unit tests.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org