You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by sa...@apache.org on 2014/09/23 12:39:09 UTC
git commit: updated refs/heads/master to 2d19bcb
Repository: cloudstack
Updated Branches:
refs/heads/master 0c3d0cc95 -> 2d19bcb46
CLOUDSTACK-6172: Adding new test case to verify this fix
Conflicts:
test/integration/component/test_volumes.py
Signed-off-by: sanjeev <sa...@apache.org>
CLOUDSTACK-6172: Fixed review comments provided in RR 25771
Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/2d19bcb4
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/2d19bcb4
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/2d19bcb4
Branch: refs/heads/master
Commit: 2d19bcb46ad7c78b4842c1f52f552998a33f8836
Parents: 0c3d0cc
Author: sanjeev <sa...@apache.org>
Authored: Thu Sep 18 14:18:14 2014 +0530
Committer: sanjeev <sa...@apache.org>
Committed: Tue Sep 23 16:08:26 2014 +0530
----------------------------------------------------------------------
test/integration/component/test_volumes.py | 138 ++++++++++++++++++++++++
1 file changed, 138 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cloudstack/blob/2d19bcb4/test/integration/component/test_volumes.py
----------------------------------------------------------------------
diff --git a/test/integration/component/test_volumes.py b/test/integration/component/test_volumes.py
index 122f2d1..36a910b 100644
--- a/test/integration/component/test_volumes.py
+++ b/test/integration/component/test_volumes.py
@@ -1209,3 +1209,141 @@ class TestDeployVmWithCustomDisk(cloudstackTestCase):
except Exception as e:
self.fail("Create volume failed with exception: %s" % e)
return
+
+class TestMigrateVolume(cloudstackTestCase):
+
+ @classmethod
+ def setUpClass(cls):
+ cls.testClient = super(TestMigrateVolume, cls).getClsTestClient()
+ cls.api_client = cls.testClient.getApiClient()
+
+ cls.services = Services().services
+ # Get Zone, Domain and templates
+ cls.domain = get_domain(cls.api_client)
+ cls.zone = get_zone(cls.api_client, cls.testClient.getZoneForTests())
+ cls.services['mode'] = cls.zone.networktype
+ cls.disk_offering = DiskOffering.create(
+ cls.api_client,
+ cls.services["disk_offering"]
+ )
+ template = get_template(
+ cls.api_client,
+ cls.zone.id,
+ cls.services["ostype"]
+ )
+ cls.services["zoneid"] = cls.zone.id
+ cls.services["virtual_machine"]["zoneid"] = cls.zone.id
+ cls.services["virtual_machine"]["template"] = template.id
+ cls.services["virtual_machine"]["diskofferingid"] = cls.disk_offering.id
+
+ # Create VMs, VMs etc
+ cls.account = Account.create(
+ cls.api_client,
+ cls.services["account"],
+ domainid=cls.domain.id
+ )
+ cls.small_offering = ServiceOffering.create(
+ cls.api_client,
+ cls.services["service_offering"]
+ )
+ cls.virtual_machine = VirtualMachine.create(
+ cls.api_client,
+ cls.services["virtual_machine"],
+ accountid=cls.account.name,
+ domainid=cls.account.domainid,
+ serviceofferingid=cls.small_offering.id,
+ mode=cls.services["mode"]
+ )
+ cls._cleanup = [
+ cls.small_offering,
+ cls.account
+ ]
+ return
+
+ @classmethod
+ def tearDownClass(cls):
+ try:
+ cleanup_resources(cls.api_client, cls._cleanup)
+ except Exception as e:
+ raise Exception("Warning: Exception during cleanup : %s" % e)
+ return
+
+ def setUp(self):
+ self.apiclient = self.testClient.getApiClient()
+ self.dbclient = self.testClient.getDbConnection()
+ self.cleanup = []
+ return
+
+ def tearDown(self):
+ cleanup_resources(self.apiclient, self.cleanup)
+ return
+
+ @attr(tags=["advanced","sg","advancedsg"], required_hardware='true')
+ def test_01_migrateVolume(self):
+ """
+ @Desc:Volume is not retaining same uuid when migrating from one storage to another.
+ Step1:Create a volume/data disk
+ Step2:Verify UUID of the volume
+ Step3:Migrate the volume to another primary storage within the cluster
+ Step4:Migrating volume to new primary storage should succeed
+ Step5:volume UUID should not change even after migration
+ """
+ vol = Volume.create(
+ self.apiclient,
+ self.services["volume"],
+ diskofferingid=self.disk_offering.id,
+ zoneid=self.zone.id,
+ account=self.account.name,
+ domainid=self.account.domainid,
+ )
+ self.assertIsNotNone(vol,"Failed to create volume")
+ vol_res = Volume.list(
+ self.apiclient,
+ id=vol.id
+ )
+ self.assertEqual(validateList(vol_res)[0],PASS,"Invalid response returned for list volumes")
+ vol_uuid=vol_res[0].id
+ try:
+ self.virtual_machine.attach_volume(
+ self.apiclient,
+ vol
+ )
+ except Exception as e:
+ self.fail("Attaching data disk to vm failed with error %s" % e)
+ pools = StoragePool.listForMigration(
+ self.apiclient,
+ id=vol.id
+ )
+ if not pools:
+ self.skipTest("No suitable storage pools found for volume migration. Skipping")
+ self.assertEqual(validateList(pools)[0],PASS,"invalid pool response from findStoragePoolsForMigration")
+ pool=pools[0]
+ self.debug("Migrating Volume-ID: %s to Pool: %s" % (vol.id,pool.id))
+ try:
+ Volume.migrate(
+ self.apiclient,
+ volumeid=vol.id,
+ storageid=pool.id,
+ livemigrate='true'
+ )
+ except Exception as e:
+ self.fail("Volume migration failed with error %s" % e)
+ migrated_vols = Volume.list(
+ self.apiclient,
+ virtualmachineid=self.virtual_machine.id,
+ listall='true',
+ type='DATADISK'
+ )
+ self.assertEqual(validateList(migrated_vols)[0],PASS,"invalid volumes response after migration")
+ migrated_vol_uuid=migrated_vols[0].id
+ self.assertEqual(
+ vol_uuid,
+ migrated_vol_uuid,
+ "Volume is not retaining same uuid when migrating from one storage to another"
+ )
+ self.virtual_machine.detach_volume(
+ self.apiclient,
+ vol
+ )
+ self.cleanup.append(vol)
+ return