You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/29 00:31:19 UTC
[GitHub] [spark] anchovYu opened a new pull request, #39269: [WIP][SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
anchovYu opened a new pull request, #39269:
URL: https://github.com/apache/spark/pull/39269
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Fix two issues in implicit lateral column alias resolution of Aggregate; added related test cases.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anchovYu commented on a diff in pull request #39269: [SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
anchovYu commented on code in PR #39269:
URL: https://github.com/apache/spark/pull/39269#discussion_r1058716520
##########
sql/core/src/test/scala/org/apache/spark/sql/LateralColumnAliasSuite.scala:
##########
@@ -547,7 +547,8 @@ class LateralColumnAliasSuite extends LateralColumnAliasSuiteBase {
test("Lateral alias of a complex type") {
// test both Project and Aggregate
- val querySuffixes = Seq("", s"FROM $testTable GROUP BY dept HAVING dept = 6")
+ // TODO(anchovyu): re-enable aggregate tests when fixed the having issue
Review Comment:
It was already broken (this is the issue that I would like to discuss with you last week), and it just happened to work due to the twist in the ~~resolution order~~ rule application order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anchovYu commented on a diff in pull request #39269: [WIP][SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
anchovYu commented on code in PR #39269:
URL: https://github.com/apache/spark/pull/39269#discussion_r1058714323
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveLateralColumnAliasReference.scala:
##########
@@ -168,19 +168,18 @@ object ResolveLateralColumnAliasReference extends Rule[LogicalPlan] {
&& aggregateExpressions.exists(_.containsPattern(LATERAL_COLUMN_ALIAS_REFERENCE)) =>
// Check if current Aggregate is eligible to lift up with Project: the aggregate
- // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) lateral
- // column alias reference or 4) literals.
+ // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) leaf
+ // expressions excluding attributes not in grouping expressions
Review Comment:
tldr, previously it doesn't allow leaf expressions other than Literal and LateralColumnAliasReference, now it allows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #39269: [SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #39269:
URL: https://github.com/apache/spark/pull/39269#issuecomment-1367129489
The failure is unrelated: `python/pyspark/sql/connect/client.py:25: error: Skipping analyzing "grpc_status": module is installed, but missing library stubs or py.typed marker`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #39269: [SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #39269:
URL: https://github.com/apache/spark/pull/39269#discussion_r1058718417
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveLateralColumnAliasReference.scala:
##########
@@ -168,19 +168,18 @@ object ResolveLateralColumnAliasReference extends Rule[LogicalPlan] {
&& aggregateExpressions.exists(_.containsPattern(LATERAL_COLUMN_ALIAS_REFERENCE)) =>
// Check if current Aggregate is eligible to lift up with Project: the aggregate
- // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) lateral
- // column alias reference or 4) literals.
+ // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) leaf
+ // expressions excluding attributes not in grouping expressions
// This check is to prevent unnecessary transformation on invalid plan, to guarantee it
// throws the same exception. For example, cases like non-aggregate expressions not
// in group by, once transformed, will throw a different exception: missing input.
def eligibleToLiftUp(exp: Expression): Boolean = {
exp match {
case e if AggregateExpression.isAggregate(e) => true
- case e if groupingExpressions.exists(_.semanticEquals(e)) => true
- case _: Literal | _: LateralColumnAliasReference => true
+ case e: Attribute if !groupingExpressions.exists(_.semanticEquals(e)) => false
Review Comment:
and do we really need both cases? I think
```
case e if groupingExpressions.exists(_.semanticEquals(e)) => true
case a: Attribute => false
```
should be sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #39269: [SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #39269:
URL: https://github.com/apache/spark/pull/39269#discussion_r1058718270
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveLateralColumnAliasReference.scala:
##########
@@ -168,19 +168,18 @@ object ResolveLateralColumnAliasReference extends Rule[LogicalPlan] {
&& aggregateExpressions.exists(_.containsPattern(LATERAL_COLUMN_ALIAS_REFERENCE)) =>
// Check if current Aggregate is eligible to lift up with Project: the aggregate
- // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) lateral
- // column alias reference or 4) literals.
+ // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) leaf
+ // expressions excluding attributes not in grouping expressions
// This check is to prevent unnecessary transformation on invalid plan, to guarantee it
// throws the same exception. For example, cases like non-aggregate expressions not
// in group by, once transformed, will throw a different exception: missing input.
def eligibleToLiftUp(exp: Expression): Boolean = {
exp match {
case e if AggregateExpression.isAggregate(e) => true
- case e if groupingExpressions.exists(_.semanticEquals(e)) => true
- case _: Literal | _: LateralColumnAliasReference => true
+ case e: Attribute if !groupingExpressions.exists(_.semanticEquals(e)) => false
Review Comment:
can we move it closer to `case e if groupingExpressions.exists(_.semanticEquals(e)) => true`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #39269: [WIP][SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #39269:
URL: https://github.com/apache/spark/pull/39269#discussion_r1058713809
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveLateralColumnAliasReference.scala:
##########
@@ -168,19 +168,18 @@ object ResolveLateralColumnAliasReference extends Rule[LogicalPlan] {
&& aggregateExpressions.exists(_.containsPattern(LATERAL_COLUMN_ALIAS_REFERENCE)) =>
// Check if current Aggregate is eligible to lift up with Project: the aggregate
- // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) lateral
- // column alias reference or 4) literals.
+ // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) leaf
+ // expressions excluding attributes not in grouping expressions
Review Comment:
what's the actual change? do we allow something new?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anchovYu commented on a diff in pull request #39269: [SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
anchovYu commented on code in PR #39269:
URL: https://github.com/apache/spark/pull/39269#discussion_r1058716520
##########
sql/core/src/test/scala/org/apache/spark/sql/LateralColumnAliasSuite.scala:
##########
@@ -547,7 +547,8 @@ class LateralColumnAliasSuite extends LateralColumnAliasSuiteBase {
test("Lateral alias of a complex type") {
// test both Project and Aggregate
- val querySuffixes = Seq("", s"FROM $testTable GROUP BY dept HAVING dept = 6")
+ // TODO(anchovyu): re-enable aggregate tests when fixed the having issue
Review Comment:
It was already broken (this is the issue that I would like to discuss with you last week), and it just happened to work due to the twist in the resolution order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #39269: [SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #39269: [SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
URL: https://github.com/apache/spark/pull/39269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #39269: [SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #39269:
URL: https://github.com/apache/spark/pull/39269#issuecomment-1367129829
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anchovYu commented on a diff in pull request #39269: [WIP][SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
anchovYu commented on code in PR #39269:
URL: https://github.com/apache/spark/pull/39269#discussion_r1058714106
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveLateralColumnAliasReference.scala:
##########
@@ -168,19 +168,18 @@ object ResolveLateralColumnAliasReference extends Rule[LogicalPlan] {
&& aggregateExpressions.exists(_.containsPattern(LATERAL_COLUMN_ALIAS_REFERENCE)) =>
// Check if current Aggregate is eligible to lift up with Project: the aggregate
- // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) lateral
- // column alias reference or 4) literals.
+ // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) leaf
+ // expressions excluding attributes not in grouping expressions
Review Comment:
Check the tests: `Leaf expression as aggregate expressions should be eligible to lift up`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #39269: [SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on code in PR #39269:
URL: https://github.com/apache/spark/pull/39269#discussion_r1058715468
##########
sql/core/src/test/scala/org/apache/spark/sql/LateralColumnAliasSuite.scala:
##########
@@ -547,7 +547,8 @@ class LateralColumnAliasSuite extends LateralColumnAliasSuiteBase {
test("Lateral alias of a complex type") {
// test both Project and Aggregate
- val querySuffixes = Seq("", s"FROM $testTable GROUP BY dept HAVING dept = 6")
+ // TODO(anchovyu): re-enable aggregate tests when fixed the having issue
Review Comment:
but it worked before this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anchovYu commented on a diff in pull request #39269: [WIP][SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
anchovYu commented on code in PR #39269:
URL: https://github.com/apache/spark/pull/39269#discussion_r1058669132
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveLateralColumnAliasReference.scala:
##########
@@ -210,14 +209,10 @@ object ResolveLateralColumnAliasReference extends Rule[LogicalPlan] {
ne.toAttribute
}.asInstanceOf[NamedExpression]
}
- if (newAggExprs.isEmpty) {
- agg
- } else {
- Project(
- projectList = projectExprs,
- child = agg.copy(aggregateExpressions = newAggExprs.toSeq)
- )
- }
+ Project(
Review Comment:
One thing I'm not sure about is if the code path for empty Aggregate expressions e.g. `Aggregate [dept] []` exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] anchovYu commented on a diff in pull request #39269: [SPARK-41631][FOLLOWUP][SQL] Fix two issues in implicit lateral column alias resolution on Aggregate
Posted by GitBox <gi...@apache.org>.
anchovYu commented on code in PR #39269:
URL: https://github.com/apache/spark/pull/39269#discussion_r1058719511
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveLateralColumnAliasReference.scala:
##########
@@ -168,19 +168,18 @@ object ResolveLateralColumnAliasReference extends Rule[LogicalPlan] {
&& aggregateExpressions.exists(_.containsPattern(LATERAL_COLUMN_ALIAS_REFERENCE)) =>
// Check if current Aggregate is eligible to lift up with Project: the aggregate
- // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) lateral
- // column alias reference or 4) literals.
+ // expression only contains: 1) aggregate functions, 2) grouping expressions, 3) leaf
+ // expressions excluding attributes not in grouping expressions
// This check is to prevent unnecessary transformation on invalid plan, to guarantee it
// throws the same exception. For example, cases like non-aggregate expressions not
// in group by, once transformed, will throw a different exception: missing input.
def eligibleToLiftUp(exp: Expression): Boolean = {
exp match {
case e if AggregateExpression.isAggregate(e) => true
- case e if groupingExpressions.exists(_.semanticEquals(e)) => true
- case _: Literal | _: LateralColumnAliasReference => true
+ case e: Attribute if !groupingExpressions.exists(_.semanticEquals(e)) => false
Review Comment:
I follow (copy) the condition in checkAnalysis, but yes I think yours is sufficient. Will change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org