You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by de...@apache.org on 2016/11/14 15:31:13 UTC

svn commit: r1769650 - in /ofbiz/trunk/applications/accounting: minilang/invoice/InvoiceServices.xml minilang/test/AutoAcctgFinAccountTests.xml servicedef/services_invoice.xml

Author: deepak
Date: Mon Nov 14 15:31:13 2016
New Revision: 1769650

URL: http://svn.apache.org/viewvc?rev=1769650&view=rev
Log:
Fixed: Conveted createInvoiceContactMech service form entity-auto to simple method, there is an bug in EntityAutoEngine. It causing test case failure. This is an quick fix. EntityAuto bug reported under ticket id OFBIZ-9117

Modified:
    ofbiz/trunk/applications/accounting/minilang/invoice/InvoiceServices.xml
    ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests.xml
    ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml

Modified: ofbiz/trunk/applications/accounting/minilang/invoice/InvoiceServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/minilang/invoice/InvoiceServices.xml?rev=1769650&r1=1769649&r2=1769650&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/minilang/invoice/InvoiceServices.xml (original)
+++ ofbiz/trunk/applications/accounting/minilang/invoice/InvoiceServices.xml Mon Nov 14 15:31:13 2016
@@ -1013,4 +1013,10 @@ under the License.
         </if-compare-field>
         <field-to-result field="isForeign"/>
     </simple-method>
+    <simple-method method-name="createInvoiceContactMech" short-description="Create a ContactMech for an invoice">
+        <make-value value-field="invoiceContactMech" entity-name="InvoiceContactMech"/>
+        <set-pk-fields map="parameters" value-field="invoiceContactMech"/>
+        <create-value value-field="invoiceContactMech"/>
+        <field-to-result field="contactMechId" result-name="invoiceContactMech"/>
+    </simple-method>
 </simple-methods>

Modified: ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests.xml?rev=1769650&r1=1769649&r2=1769650&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests.xml (original)
+++ ofbiz/trunk/applications/accounting/minilang/test/AutoAcctgFinAccountTests.xml Mon Nov 14 15:31:13 2016
@@ -206,9 +206,7 @@ under the License.
         <entity-one entity-name="UserLogin" value-field="userLogin">
             <field-map field-name="userLoginId" value="system"/>
         </entity-one>
-        <set field="serviceCtx.userLogin" from-field="userLogin">
-            <results-to-map map-name="finAccountAuthResult"/>
-        </set>
+        <set field="serviceCtx.userLogin" from-field="userLogin"/>
         <call-service service-name="setFinAccountTransStatus" in-map-name="serviceCtx">
             <results-to-map map-name="serviceResult"/>
         </call-service>

Modified: ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml?rev=1769650&r1=1769649&r2=1769650&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml (original)
+++ ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml Mon Nov 14 15:31:13 2016
@@ -301,7 +301,8 @@ under the License.
         <description>Checks to see if the payments applied to an invoice total up to the invoice total; if so sets to PAID</description>
         <attribute name="invoiceId" type="String" mode="IN" optional="false"/>
     </service>
-    <service name="createInvoiceContactMech" engine="entity-auto" invoke="create" default-entity-name="InvoiceContactMech">
+    <service name="createInvoiceContactMech" engine="simple" location="component://accounting/minilang/invoice/InvoiceServices.xml"
+             invoke="createInvoiceContactMech" default-entity-name="InvoiceContactMech">
         <description>Create a ContactMech for an invoice</description>
         <permission-service service-name="acctgInvoicePermissionCheck" main-action="CREATE"/>
         <auto-attributes include="pk" mode="IN" optional="false"/>