[GitHub] [spark] xkrogen commented on pull request #33446: [SPARK-36215][SHUFFLE] Add logging for slow fetches to diagnose external shuffle service issues

[GitBox <gi...@apache.org>]

xkrogen commented on pull request #33446:
URL: https://github.com/apache/spark/pull/33446#issuecomment-884559830


   > In the current state of the PR, logging will only happen if the last request to be completed was successful. Should we instead add logging to both `onSuccess` and `onFailure`?
   
   If we have a failure we'll already get the error log that the fetch failed, but I suppose it could be useful to also be aware if it was performing slowly before the failure (maybe it's related to the failure), so it seems worth it to check in `onFailure` as well. Good idea!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org