[jira] [Created] (GROOVY-12303) ClassNodeResolver: NoClassDefFoundError during class-loader lookup aborts resolution

["Daniel Sun (Jira)" <ji...@apache.org>]

Daniel Sun created GROOVY-12303:
-----------------------------------

             Summary: ClassNodeResolver: NoClassDefFoundError during class-loader lookup aborts resolution
                 Key: GROOVY-12303
                 URL: https://issues.apache.org/jira/browse/GROOVY-12303
             Project: Groovy
          Issue Type: Bug
            Reporter: Daniel Sun


When class-loader lookup is used ({{{}asmResolving{}}} off, or the type exists only in memory), {{ClassNodeResolver}} calls {{{}GroovyClassLoader.loadClass{}}}. If the requested class *exists* but cannot be linked (missing superclass or interface), the JVM throws {{{}NoClassDefFoundError{}}}.

That error used to escape resolution. Compilation aborted with an {{Error}} that named the {*}missing dependency{*}, not the type being resolved. {{resolveName}} could also cache the name as a miss ({{{}NO_CLASS{}}}), so a later successful compile of the dependency would not be retried.

A TODO in {{findByClassLoading}} has noted this since the 2012 split out of {{{}ResolveVisitor{}}}.
h3. Expected
 * If bytecode for the requested name is still on the class path, decompile it (ASM does not link) and continue.
 * Else if a groovy source of the same name is available, add it to the compilation queue.
 * Else if a {{.class}} resource exists for that path but declares a different binary name (JVM {{defineClass}} name check; also case-insensitive filesystems), treat the lookup as a miss. Detect this from the bytecode name, not from {{NoClassDefFoundError}} text (HotSpot's {{wrong name}} phrase is English-only; OpenJ9 does not use it).
 * Otherwise rethrow {{NoClassDefFoundError}} with the looked-up name in the message, and do not cache {{{}NO_CLASS{}}}.

h3. Actual

{{NoClassDefFoundError}} propagated out of {{{}ClassNodeResolver.findByClassLoading{}}}.
h3. Reproducer

Put {{HasDep.class}} (extends a type that is not loadable) on the class path, disable ASM resolving, and compile:
{code:groovy}
HasDep x = null
{code}
This fails with {{NoClassDefFoundError}} for the missing super-type instead of resolving {{{}HasDep{}}}.

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)