[GitHub] [incubator-ponymail-foal] sebbASF opened a new issue #201: get_source does not need support fetch by Permalink

[GitBox <gi...@apache.org>]

sebbASF opened a new issue #201:
URL: https://github.com/apache/incubator-ponymail-foal/issues/201


   https://github.com/apache/incubator-ponymail-foal/blob/5b1cd7594d11812602c6cf8a8f7e3889d0145b81/server/plugins/messages.py#L302
   
   AFAICT it's not necessary for get_source to check for a match by Permalink.
   This is because the link to a source document is always the unique database id.
   The Migration tool converts the references.
   
   A search of the source code shows that the function is always called with the dbid.
   
   So every incorrect dbid results in an unnecessary search.
   
   The search by permalink could be dropped (or at least disabled unless specifically requested).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ponymail-foal] sebbASF closed issue #201: get_source does not need support fetch by Permalink

[GitBox <gi...@apache.org>]

sebbASF closed issue #201:
URL: https://github.com/apache/incubator-ponymail-foal/issues/201


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ponymail.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org