You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Aihua Xu <ax...@cloudera.com> on 2017/10/02 21:09:25 UTC
Review Request 62736: HIVE-17544: Provide classname info for function
authorization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62736/
-----------------------------------------------------------
Review request for hive.
Repository: hive-git
Description
-------
HIVE-17544: Provide classname info for function authorization
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/Driver.java f01edf8156205ea452178f6539e5bbfe29742428
ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java 820e4e2f67506e21efa0a1c7aaa37fb1c4b88f55
ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 4707c4d1bbc71e256b16511f48f8650c027773fe
ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java c5380750f23cc731d33354ea09858882b2364ce7
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 570571b274a090e2147d3ac485194082be12b813
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObject.java fb4c3206be3a92b3fd52826082fe103d5f445d0e
Diff: https://reviews.apache.org/r/62736/diff/1/
Testing
-------
Thanks,
Aihua Xu
Re: Review Request 62736: HIVE-17544: Provide classname info for
function authorization
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62736/#review186897
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Oct. 2, 2017, 9:10 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62736/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 9:10 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-17544: Provide classname info for function authorization
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java f01edf8156205ea452178f6539e5bbfe29742428
> ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java 820e4e2f67506e21efa0a1c7aaa37fb1c4b88f55
> ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 4707c4d1bbc71e256b16511f48f8650c027773fe
> ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java c5380750f23cc731d33354ea09858882b2364ce7
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 570571b274a090e2147d3ac485194082be12b813
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObject.java fb4c3206be3a92b3fd52826082fe103d5f445d0e
>
>
> Diff: https://reviews.apache.org/r/62736/diff/1/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Aihua Xu
>
>
Re: Review Request 62736: HIVE-17544: Provide classname info for
function authorization
Posted by Aihua Xu <ax...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62736/#review186894
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java
Line 259 (original), 273 (patched)
<https://reviews.apache.org/r/62736/#comment263771>
Other analyzer will call different constructurs here, so className will be null by default and we will only have className set for Functions.
- Aihua Xu
On Oct. 2, 2017, 9:10 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62736/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 9:10 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-17544: Provide classname info for function authorization
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java f01edf8156205ea452178f6539e5bbfe29742428
> ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java 820e4e2f67506e21efa0a1c7aaa37fb1c4b88f55
> ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 4707c4d1bbc71e256b16511f48f8650c027773fe
> ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java c5380750f23cc731d33354ea09858882b2364ce7
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 570571b274a090e2147d3ac485194082be12b813
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObject.java fb4c3206be3a92b3fd52826082fe103d5f445d0e
>
>
> Diff: https://reviews.apache.org/r/62736/diff/1/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Aihua Xu
>
>
Re: Review Request 62736: HIVE-17544: Provide classname info for
function authorization
Posted by Na Li <li...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62736/#review186892
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java
Line 259 (original), 273 (patched)
<https://reviews.apache.org/r/62736/#comment263769>
is Entity only created by Function semantic anaylyzer? If not, then other analyzer should be changed to provide input for className (null) when creating Entity.
- Na Li
On Oct. 2, 2017, 9:10 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62736/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 9:10 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-17544: Provide classname info for function authorization
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java f01edf8156205ea452178f6539e5bbfe29742428
> ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java 820e4e2f67506e21efa0a1c7aaa37fb1c4b88f55
> ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 4707c4d1bbc71e256b16511f48f8650c027773fe
> ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java c5380750f23cc731d33354ea09858882b2364ce7
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 570571b274a090e2147d3ac485194082be12b813
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObject.java fb4c3206be3a92b3fd52826082fe103d5f445d0e
>
>
> Diff: https://reviews.apache.org/r/62736/diff/1/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Aihua Xu
>
>
Re: Review Request 62736: HIVE-17544: Provide classname info for
function authorization
Posted by Sergio Pena <se...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62736/#review187000
-----------------------------------------------------------
Ship it!
Ship It!
- Sergio Pena
On Oct. 2, 2017, 9:10 p.m., Aihua Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62736/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2017, 9:10 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-17544: Provide classname info for function authorization
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java f01edf8156205ea452178f6539e5bbfe29742428
> ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java 820e4e2f67506e21efa0a1c7aaa37fb1c4b88f55
> ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 4707c4d1bbc71e256b16511f48f8650c027773fe
> ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java c5380750f23cc731d33354ea09858882b2364ce7
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 570571b274a090e2147d3ac485194082be12b813
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObject.java fb4c3206be3a92b3fd52826082fe103d5f445d0e
>
>
> Diff: https://reviews.apache.org/r/62736/diff/1/
>
>
> Testing
> -------
>
> Manually tested.
>
>
> Thanks,
>
> Aihua Xu
>
>
Re: Review Request 62736: HIVE-17544: Provide classname info for
function authorization
Posted by Aihua Xu <ax...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62736/
-----------------------------------------------------------
(Updated Oct. 2, 2017, 9:10 p.m.)
Review request for hive.
Repository: hive-git
Description
-------
HIVE-17544: Provide classname info for function authorization
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/Driver.java f01edf8156205ea452178f6539e5bbfe29742428
ql/src/java/org/apache/hadoop/hive/ql/hooks/Entity.java 820e4e2f67506e21efa0a1c7aaa37fb1c4b88f55
ql/src/java/org/apache/hadoop/hive/ql/hooks/WriteEntity.java 4707c4d1bbc71e256b16511f48f8650c027773fe
ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java c5380750f23cc731d33354ea09858882b2364ce7
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java 570571b274a090e2147d3ac485194082be12b813
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HivePrivilegeObject.java fb4c3206be3a92b3fd52826082fe103d5f445d0e
Diff: https://reviews.apache.org/r/62736/diff/1/
Testing (updated)
-------
Manually tested.
Thanks,
Aihua Xu